This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Check debugging is enabled before restoring the session #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
changed the title
|
This does not support changing kernels for existing notebook, which should be handled in #76. |
jtpio
commented
Dec 11, 2019
| this._client.iopubMessage.connect(this._handleEvent, this); | ||
|
|
||
| if (this.client instanceof ClientSession) { | ||
| this._ready = this.client.ready.then(_ => this.client.kernel.ready); |
There was a problem hiding this comment.
This is required to be able to retrieve the kernel info.
jtpio
force-pushed
the
debugging-enabled
branch
from
122d2d1 to
870620c
Compare
jtpio
changed the title
|
This approach will probably slightly change when we'll have to also handle kernel changes:
|
Closed
jtpio
force-pushed
the
debugging-enabled
branch
from
870620c to
97e7c61
Compare
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268.
Check whether a kernel support debugging before restoring the session and sending the
debugInfomessage.