Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Breakpoints removed from the sidebar on notebook closed #291

Closed
wants to merge 3 commits into from

Conversation

KsavinN
Copy link
Collaborator

@KsavinN KsavinN commented Dec 16, 2019

Resolved by Jeremy in PR #308

This branch needs to be rebased and refactored after this PR #290

resolve issue #168.

  • after close all notebooks clear breakpoints.

After close widget:

clearBreakpoints

@KsavinN KsavinN added bug Something isn't working ui labels Dec 16, 2019
@KsavinN KsavinN added this to the 0.1.0 milestone Dec 16, 2019
@KsavinN KsavinN self-assigned this Dec 16, 2019
@jtpio
Copy link
Member

jtpio commented Dec 16, 2019

Should we really clear the breakpoints from the state in the kernel? Or just from the UI?

If we re-open the notebook the breakpoints will be gone, even if the kernel was not shut down.

@KsavinN
Copy link
Collaborator Author

KsavinN commented Dec 16, 2019

Should we really clear the breakpoints from the state in the kernel? Or just from the UI?

If we re-open the notebook the breakpoints will be gone, even if the kernel was not shut down.

It should still have breakpoints. It should only clear UI.
stillSHow

@KsavinN KsavinN marked this pull request as ready for review December 16, 2019 16:04
@KsavinN KsavinN requested review from jtpio and afshin December 16, 2019 16:40
src/index.ts Outdated Show resolved Hide resolved
@KsavinN KsavinN force-pushed the removing-breakpoints-bug branch from 39590d4 to 94e8d33 Compare December 17, 2019 16:02
@KsavinN KsavinN removed bug Something isn't working work in progress labels Dec 18, 2019
@KsavinN KsavinN requested a review from jtpio December 18, 2019 10:43
@jtpio
Copy link
Member

jtpio commented Dec 18, 2019

This shouldn't be specific to breakpoints only. There is a similar issue when the execution is stopped and the notebook is closed:

dispose-on-execution-stopped

Maybe there could be a more generic model cleanup method that would be triggered when the widget is disposed? The sidebar would react to model changes and clean itself up.

@jtpio
Copy link
Member

jtpio commented Dec 18, 2019

Ideally this would also handle kernel changes, so the sidebar UI would be cleared when the kernel is changed:

clear-sidebar-kernel-changed

This was referenced Dec 18, 2019
@KsavinN KsavinN closed this Dec 20, 2019
@KsavinN KsavinN deleted the removing-breakpoints-bug branch December 20, 2019 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants