Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Hide the sidebar if no kernel supports debugging #505

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Hide the sidebar if no kernel supports debugging #505

merged 1 commit into from
Jul 22, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 22, 2020

Fixes #289.

hide-sidebar

@jtpio jtpio added this to the 0.3.0 milestone Jul 22, 2020
@jtpio
Copy link
Member Author

jtpio commented Jul 22, 2020

This approach of just hiding the sidebar (or rather not adding it) instead of disabling the plugin all together (for example by not providing the IDebugger token), means that there is still a hint about the debugger extension in the settings:

image

afshin
afshin approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@afshin afshin merged commit 46cfe12 into jupyterlab:master Jul 22, 2020
@jtpio jtpio deleted the hide-sidebar branch July 22, 2020 19:27
@jtpio jtpio mentioned this pull request Jul 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Toggle button and sidebar visibility
2 participants
@jtpio @afshin