Adopt sp-repo-review #414
Merged
Adopt sp-repo-review #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
force-pushed
the
sp-repo-review
branch
from
907a94d to
dce54bd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| """Overload the regular finish, which (sensibly) always sets JSON""" | ||
| self.update_api_activity() | ||
| self.set_header("Content-Type", _mime_type) | ||
| return super(APIHandler, self).finish(*args, **kwargs) | ||
| return await super(APIHandler, self).finish(*args, **kwargs) |
Check failure
Code scanning / CodeQL
First argument to super() is not enclosing class
Comment on lines
+21
to
+29
| def initialize( # type:ignore[override] | ||
| self, | ||
| name: str, | ||
| app_settings_dir: str, | ||
| schemas_dir: str, | ||
| settings_dir: str, | ||
| labextensions_path: list[str], | ||
| **kwargs: Any, | ||
| ) -> None: |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method
blink1073
force-pushed
the
sp-repo-review
branch
from
1462e53 to
bae9a4e
Compare
blink1073
force-pushed
the
sp-repo-review
branch
from
5db4012 to
a69a3f6
Compare
blink1073
force-pushed
the
sp-repo-review
branch
from
42fb8be to
df79df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt pypi.org/project/sp-repo-review, which has a standard set of checks for packages in the scientific python ecosystem, as seen in learn.scientific-python.org/development.