Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dragdrop to use PointerEvent and DragEvent #355

Merged
merged 5 commits into from
Aug 19, 2022
Merged

Update dragdrop to use PointerEvent and DragEvent #355

merged 5 commits into from
Aug 19, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Aug 18, 2022 •
edited
Loading

  • This PR updates @lumino/dragdrop to use new PointerEvent(...) instances or sub-classes of DragEvent instead of initMouseEvent, which is deprecated.
  • This PR moves the DropAction and SupportedActions type definitions into the Drag namespace. This does not seem to affect any downstream Lumino or JupyterLab code.
  • This PR deprecates the IDragEvent interface and suggests client code use Drag.Event instead.

Fixes #353
Partially fixes #340

Public API changes

@lumino/dragdrop

export name note
❌ type DropAction Moved to Drag.DropAction
❌ type SupportedActions Moved to Drag.SupportedActions
☑️ interface IDragEvent @deprecated, use Drag.Event instead

@afshin afshin added the maintenance Dependencies, build, technical debt, etc. label Aug 18, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 18, 2022
@afshin afshin self-assigned this Aug 18, 2022
@afshin afshin changed the title Initmouseevent is deprecated Update @lumino/dragdrop to use PointerEvent and DragEvent Aug 18, 2022
@afshin afshin changed the title Update @lumino/dragdrop to use PointerEvent and DragEvent Update dragdrop to use PointerEvent and DragEvent Aug 18, 2022
@afshin
Use a sub-class of DragEvent for Drag.Event, move internally used typ…
83ca8d1 
…es into Drag namespace, deprecate IDragEvent interface
@afshin afshin force-pushed the initmouseevent-is-deprecated branch from a8caf41 to 83ca8d1 Compare August 18, 2022 15:10
@afshin afshin marked this pull request as ready for review August 18, 2022 15:24
@afshin afshin marked this pull request as draft August 18, 2022 20:22
@afshin afshin marked this pull request as ready for review August 19, 2022 11:14
fcollonval
fcollonval approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcollonval fcollonval merged commit a1df432 into jupyterlab:main Aug 19, 2022
@fcollonval fcollonval mentioned this pull request Sep 15, 2022
Closed
8 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@afshin afshin

Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
Lumino 2
2 participants
@afshin @fcollonval