-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input to configure the yarn command via npm_client
#196
Conversation
An alternative could be to specify the yarn version in as an input instead, and let the action set up yarn directly. |
@@ -15,6 +15,10 @@ inputs: | |||
required: true | |||
|
|||
# Optional inputs | |||
yarn_cmd: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe this could be named npm_client
similar to what lerna
uses in lerna.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in eaef4b7
npm_client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add support for providing a custom yarn command for the
jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1
action.This is useful to provide a custom yarn version, or
jlpm
which has been updated to yarn 3.