Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input to configure the yarn command via npm_client #196

Merged
merged 5 commits into from
May 25, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 18, 2023

Add support for providing a custom yarn command for the jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1 action.

This is useful to provide a custom yarn version, or jlpm which has been updated to yarn 3.

@jtpio jtpio added the enhancement New feature or request label May 18, 2023
@jtpio
Copy link
Member Author

jtpio commented May 22, 2023

An alternative could be to specify the yarn version in as an input instead, and let the action set up yarn directly.

@@ -15,6 +15,10 @@ inputs:
required: true

# Optional inputs
yarn_cmd:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this could be named npm_client similar to what lerna uses in lerna.json.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in eaef4b7

@jtpio jtpio changed the title Add input to configure the yarn command Add input to configure the yarn command via npm_client May 22, 2023
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtpio jtpio merged commit 043b876 into jupyterlab:main May 25, 2023
@jtpio jtpio deleted the yarn-cmd branch May 25, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants