Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Ignore Link Patterns #30

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Mar 17, 2021

Adds the following:

--link-check-ignore

A regular expression that matches URIs that should not be checked.
Can be specified multiple times for multiple ignore patterns.
This can be used for files that have a lot of links to GitHub pages,
such as a Changelog. GitHub has rate limiting, which would normally cause these files to take up to an hour to complete for larger repositories. For example:

pytest --check-links --link-check-ignore "https://github.com/.*/pull/.*" CHANGELOG.md

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #30 (a168bde) into master (66ba680) will increase coverage by 0.33%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   89.55%   89.89%   +0.33%     
==========================================
  Files           3        3              
  Lines         268      277       +9     
==========================================
+ Hits          240      249       +9     
  Misses         28       28              
Impacted Files Coverage Δ
pytest_check_links/plugin.py 92.05% <92.30%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ba680...a168bde. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@bollwyvl
Copy link
Contributor

Just the one nitpick about the name of the new arg, but otherwise looks great. It's weird the coverage didn't pick it up...

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants