Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rst handling #4

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Add rst handling #4

merged 5 commits into from
Jan 9, 2019

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Jul 28, 2018

We switched from md to rst in JupyterLab and we were getting some link rot.

Also allows for relative links to supported file extensions.

@blink1073
Copy link
Contributor Author

Examples of what this catches:

=================================== FAILURES ===================================
 /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/adding_content.rst: https://github.com/jupyterlab/jupyterlab/blob/master/packages/terminal/typings/xterm/xterm.d.ts
https://github.com/jupyterlab/jupyterlab/blob/master/packages/terminal/typings/xterm/xterm.d.ts: HTTP Error 404: Not Found
 /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/adding_content.rst: documents.html
documents.html: No such file: /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/documents.html
 /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/documents.rst: http://jupyterlab.github.io/jupyterlab/interfaces/_docregistry_src_registry_.documentregistry.ireadywidget.html
http://jupyterlab.github.io/jupyterlab/interfaces/_docregistry_src_registry_.documentregistry.ireadywidget.html: HTTP Error 404: Not Found
 /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/extension_dev.rst: ./notebook.html#how-to-extend-the-notebook-plugin
./notebook.html#how-to-extend-the-notebook-plugin: No such file: /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/notebook.html
 /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/notebook.rst: http://jupyterlab.github.io/jupyterlab/modules/_notebook_src_actions_.notebookactions.html
http://jupyterlab.github.io/jupyterlab/modules/_notebook_src_actions_.notebookactions.html: HTTP Error 404: Not Found
 /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/xkcd_extension_tutorial.rst: README.html#getting-help
README.html#getting-help: No such file: /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/README.html
 /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/xkcd_extension_tutorial.rst: ./extension_dev.html
./extension_dev.html: No such file: /Users/ssilvester/workspace/jupyter/lab/docs/source/developer/extension_dev.html
============ 7 failed, 192 passed, 422 deselected in 70.31 seconds =============

@minrk minrk merged commit bd975b0 into jupyterlab:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants