Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Switch cell type from the cell menu #328

Merged
merged 5 commits into from
Jan 27, 2022
Merged

Switch cell type from the cell menu #328

merged 5 commits into from
Jan 27, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 26, 2022

Iteration towards https://github.com/jupyterlab/retrolab/issues/259

Update the menus to:

  • Rename the top-level Run to Cell like in the current classic notebook v6
  • Add submenu to change the cell type

RetroLab

image

Notebook v6

image

@jtpio jtpio added this to the 0.3.x milestone Jan 26, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/retrolab/menus

@jtpio jtpio added the enhancement New feature or request label Jan 26, 2022
@jtpio
Copy link
Member Author

jtpio commented Jan 26, 2022

TODO: this should not affect the JupyterLab menus:

image

Reported upstream in jupyterlab/jupyterlab#11754

@jtpio
Copy link
Member Author

jtpio commented Jan 26, 2022

A temporary workaround would be to add the menu items programmatically in the plugin instead of using the settings system.

@jtpio jtpio marked this pull request as ready for review January 26, 2022 16:54
@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2022

Let's merge, and we can investigate how to properly use the settings system as a follow-up (jupyterlab/jupyterlab#11754).

@jtpio jtpio merged commit 0417734 into jupyterlab:main Jan 27, 2022
@jtpio jtpio deleted the menus branch January 27, 2022 07:23
@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2022

@meeseeksdev please backport to 0.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 27, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 04177343498723eec84e0547f28287262a3158fe
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR jupyter/retrolab#328: Switch cell type from the cell menu'
  1. Push to a named branch:
git push YOURFORK 0.3.x:auto-backport-of-pr-328-on-0.3.x
  1. Create a PR against branch 0.3.x, I would have named this PR:

"Backport PR #328 on branch 0.3.x (Switch cell type from the cell menu)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

jtpio added a commit to jtpio/retrolab that referenced this pull request Jan 27, 2022
jtpio added a commit that referenced this pull request Jan 27, 2022
Backport PR #328: Switch cell type from the cell menu
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant