Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a list for piplite_urls #161

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

bollwyvl
Copy link
Contributor

references

changes

  • use List instead of TypedTuple for piplite_urls
  • test 0, 1, and 2 entries
  • handle duplicate wheels, e.g. --piplite-urls . --piplite-urls ./some-package....whl
    • emits a log.warning, but doesn't fail

user-facing changes

  • site builders should be able to pass 0, 1, or n wheels
    • if multiple wheels with exactly the same name are discovered, only one will be indexed (not sure which, but better than failing)
  • site users should see no change

backwards-incompatible changes

  • i guess piplite_urls is a list now, not a tuple. but the tuple typing was wrong anyway, so likely nobody will notice

future work

  • we really need upstream to have better types.
    • doit makes this somewhat tricky, as there is no community-maintained types-doit, and we really only care about a very small proportion of them
    • jupyterlite_core is probably easier, but there's still rather a lot going on

Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@bollwyvl bollwyvl added the enhancement New feature or request label Jan 17, 2025
@bollwyvl bollwyvl marked this pull request as ready for review January 17, 2025 17:00
@bollwyvl bollwyvl requested review from jtpio and Carreau January 17, 2025 17:00
@bollwyvl bollwyvl changed the base branch from main to 0.5.x January 17, 2025 17:10
@jtpio jtpio changed the base branch from 0.5.x to main January 17, 2025 17:17
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I changed the base branch back to main based on #160 (comment).

Will follow-up with the backport + releases.

@jtpio jtpio merged commit dffb813 into jupyterlite:main Jan 17, 2025
15 of 16 checks passed
@jtpio
Copy link
Member

jtpio commented Jan 17, 2025

@meeseeksdev please backport to 0.5.x

meeseeksmachine pushed a commit to meeseeksmachine/pyodide-kernel that referenced this pull request Jan 17, 2025
jtpio pushed a commit that referenced this pull request Jan 17, 2025
@Carreau
Copy link

Carreau commented Jan 20, 2025

thanks!

@bollwyvl bollwyvl deleted the fix-single-wheel-cli branch January 20, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants