Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references
traitlets.config
issuechanges
List
instead ofTypedTuple
forpiplite_urls
--piplite-urls . --piplite-urls ./some-package....whl
log.warning
, but doesn't failuser-facing changes
backwards-incompatible changes
piplite_urls
is a list now, not a tuple. but the tuple typing was wrong anyway, so likely nobody will noticefuture work
doit
makes this somewhat tricky, as there is no community-maintainedtypes-doit
, and we really only care about a very small proportion of themjupyterlite_core
is probably easier, but there's still rather a lot going on