Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation #50

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Add documentation #50

merged 9 commits into from
Jan 29, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jan 26, 2024 •
edited
Loading

Fix #17

TODO:

  • Document extra mount points
  • Document mounting jupyterlite content
  • Use jupyterlite and xeus logos

@martinRenou martinRenou added the documentation Improvements or additions to documentation label Jan 26, 2024
@martinRenou martinRenou reopened this Jan 26, 2024
@martinRenou martinRenou marked this pull request as ready for review January 29, 2024 09:29
@martinRenou
Copy link
Member Author

Let's write a bit more about mount points once #45 is resolved

jtpio
jtpio approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a first pass, thanks!

Maybe we can also update this page in the main JupyterLite documentation? https://jupyterlite.readthedocs.io/en/stable/howto/xeus-python/preinstalled_packages.html

@jtpio
Copy link
Member

jtpio commented Jan 29, 2024

Also would it be possible to be added to the project on ReadTheDocs? (just in case and to increase the number of maintainers)

@martinRenou
Copy link
Member Author

martinRenou commented Jan 29, 2024 •
edited
Loading

Sounds good! Thank you

@martinRenou martinRenou merged commit bc03064 into jupyterlite:main Jan 29, 2024
12 checks passed
@martinRenou martinRenou deleted the docs branch January 29, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

@DerThorsten DerThorsten Awaiting requested review from DerThorsten

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add nicer documentation on readthedocs (or github pages hosted)
2 participants
@martinRenou @jtpio