Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI for a PR #8

Closed
juri-sinitson opened this issue Dec 21, 2023 · 0 comments
Closed

Set up CI for a PR #8

juri-sinitson opened this issue Dec 21, 2023 · 0 comments
Assignees
@juri-sinitson
Labels
build Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)

Comments

@juri-sinitson
Copy link
Owner

juri-sinitson commented Dec 21, 2023 •
edited
Loading

TODOs

For a PR to be created the following must be checked automatically:

  1. Component Tests/Storybook tests must pass: done
  2. E2E tests must pass: done
  3. Unit tests must pass: done
  4. Linting must pass: done

INFO

See
https://blog.nrwl.io/nx-17-2-update-b8f23ec42cbb#89f3
https://nx.dev/ci/features/nx-agents
@juri-sinitson juri-sinitson added the build Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) label Dec 21, 2023
@juri-sinitson juri-sinitson self-assigned this Dec 21, 2023
@juri-sinitson juri-sinitson changed the title Set up deployment for a PR Set up CI for a PR Mar 15, 2024
@juri-sinitson juri-sinitson linked a pull request Mar 15, 2024 that will close this issue
ci first try #18
Closed
juri-sinitson added a commit that referenced this issue Mar 15, 2024
@juri-sinitson
ci(github-actions): #8 add and test the ci config for PRs
93eaad1 
- See also:
https://nx.dev/ci/intro/tutorials/github-actions
https://nx.dev/ci/intro/ci-with-nx
juri-sinitson added a commit that referenced this issue Mar 18, 2024
@juri-sinitson
refactor(docs): #8 improve the docs
8b47757 
Regarding:
1. CI
2. Remote cache, see https://nx.dev/ci/features/remote-cache
and https://nx.dev/ci/concepts/cache-security
juri-sinitson added a commit that referenced this issue Mar 19, 2024
@juri-sinitson
refactor(docs): #8 improve the docs
5aec250 
Regarding:
1. The access token (https://nx.dev/ci/recipes/security/access-tokens) to the nx cloud (https://nx.app/).
juri-sinitson added a commit that referenced this issue Mar 19, 2024
@juri-sinitson
ci(github-actions): #8 improvements and fixes
168ae97 
- Print the `NX_BASE` and `NX_HEAD` for debug purposes
(see also https://nx.dev/reference/environment-variables)
- Fix failing CI when pushing directly to `main` to avoid
CI  fails when the changes author, the reviewer and code
owner is the same person.
juri-sinitson pushed a commit that referenced this issue Mar 20, 2024
docs(README): #8 add missing examples
ae573c7
juri-sinitson pushed a commit that referenced this issue Mar 20, 2024
docs(README): #8 regenerate the TOC
7669539
juri-sinitson pushed a commit that referenced this issue Mar 20, 2024
docs(README): #8 add missing examples
a8dfcfc
juri-sinitson pushed a commit that referenced this issue Mar 20, 2024
docs(README): #8 regenerate the TOC
3621344
juri-sinitson pushed a commit that referenced this issue Mar 20, 2024
docs(README): #8 add missing examples
0e17118
juri-sinitson pushed a commit that referenced this issue Mar 20, 2024
docs(README): #8 regenerate the TOC
d56ec13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juri-sinitson juri-sinitson

Labels
build Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci first try juri-sinitson/angular-monorepo
1 participant
@juri-sinitson