Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast TokenValue.__str__ return value to string #74

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Cast TokenValue.__str__ return value to string #74

merged 3 commits into from
Jul 15, 2022

Conversation

delkopiso
Copy link
Contributor

fixes #69

@delkopiso delkopiso mentioned this pull request Jul 12, 2022
Closed
alexgarel
alexgarel approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool change.

I approve so you can merge as is, but if you find the time to add a test that would be super-cool :-)

alexgarel
alexgarel requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my first approval was a bit too quick. Can you consider my suggestion ?

luqum/head_tail.py Outdated Show resolved Hide resolved
@delkopiso @alexgarel
make requested change
55ce80e 
Co-authored-by: Alex Garel <[email protected]>
@delkopiso
Copy link
Contributor Author

@alexgarel that makes sense, I've applied your suggestion.

alexgarel
alexgarel approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much :-)

@alexgarel alexgarel merged commit cd54380 into jurismarches:master Jul 15, 2022
@delkopiso delkopiso deleted the patch-1 branch July 15, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser fails with 'TypeError' on invalid query "~]"
2 participants
@delkopiso @alexgarel