Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation, accelerometer and gyro data format as well as scaling factors #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

StefanKrupop
Copy link

I fixed the basic errors to get the node to compile on a Raspberry Pi (current Raspbian).
Also added the mandatory license tag to package.xml. I left the default "BSD" in there, as I found no license information in the code. Please check and decide on a license.
Also the accelerometer and gyroscope data was the wrong endianness.
Lastly, I changed the scaling factors to match what's in the datasheet (mostly the accelerometer was off).
Values that are now returned at least look like they could be plausible.

- Added mandatory license tag to package.xml (Not sure which license to choose, found no info in existing code)
- Fixed copy&paste errors
- Fixed syntax errors
- Include some SMBUS functions from libi2c directly
@robert-meiner
Copy link

robert-meiner commented Jun 16, 2020

I got this to build using catkin tools. I get this warning about generating messages, though. Is there a fix for this?

pi@antonio:~/catkin_ws $ catkin build
----------------------------------------------------------------------
Profile:                     default
Extending:             [env] /opt/ros/melodic:/home/pi/catkin_ws/devel
Workspace:                   /home/pi/catkin_ws
----------------------------------------------------------------------
Build Space:        [exists] /home/pi/catkin_ws/build
Devel Space:        [exists] /home/pi/catkin_ws/devel
Install Space:      [unused] /home/pi/catkin_ws/install
Log Space:          [exists] /home/pi/catkin_ws/logs
Source Space:       [exists] /home/pi/catkin_ws/src
DESTDIR:            [unused] None
----------------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        None
----------------------------------------------------------------------
Additional CMake Args:       -DCMAKE_BUILD_TYPE=Release
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
----------------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
----------------------------------------------------------------------
Workspace configuration appears valid.
----------------------------------------------------------------------
[build] Found '1' packages in 0.0 seconds.                                           
[build] Updating package table.                                                      
Starting  >>> mpu9250_9dof_imu                                                       
_____________________________________________________________________________________
Warnings   << mpu9250_9dof_imu:cmake /home/pi/catkin_ws/logs/mpu9250_9dof_imu/build.cmake.000.log
CMake Warning at /home/pi/catkin_ws/build/mpu9250_9dof_imu/cmake/mpu9250_9dof_imu-genmsg.cmake:3 (message):
  Invoking generate_messages() without having added any message or service
  file before.

  You should either add add_message_files() and/or add_service_files() calls
  or remove the invocation of generate_messages().
Call Stack (most recent call first):
  /opt/ros/melodic/share/genmsg/cmake/genmsg-extras.cmake:307 (include)
  CMakeLists.txt:24 (generate_messages)


cd /home/pi/catkin_ws/build/mpu9250_9dof_imu; catkin build --get-env mpu9250_9dof_imu | catkin env -si  /usr/bin/cmake /home/pi/catkin_ws/src/ros-mpu9250-imu --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/pi/catkin_ws/devel/.private/mpu9250_9dof_imu -DCMAKE_INSTALL_PREFIX=/home/pi/catkin_ws/install -DCMAKE_BUILD_TYPE=Release; cd -
.....................................................................................
Finished  <<< mpu9250_9dof_imu                [ 18.5 seconds ]                       
[build] Summary: All 1 packages succeeded!                                           
[build]   Ignored:   None.                                                           
[build]   Warnings:  1 packages succeeded with warnings.                             
[build]   Abandoned: None.                                                           
[build]   Failed:    None.                                                           
[build] Runtime: 18.6 seconds total.                                                 
[build] Note: Workspace packages have changed, please re-source setup files to use them.
pi@antonio:~/catkin_ws $ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants