Add custom parameter parsing to Slackify #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this is sweet! I'm fine with the changes for the last commit. Once #12 is shipped, we can ship this one. |
DougEdey
force-pushed
the
custom_params
branch
4 times, most recently
from
b552820 to
fed1a5c
Compare
jusleg
approved these changes
Sep 5, 2020
DougEdey
force-pushed
the
custom_params
branch
from
fed1a5c to
9a12ca7
Compare
DougEdey
force-pushed
the
custom_params
branch
from
9a12ca7 to
53fea20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #12 so please just focus on the top commit (it's nice and small)
This allows Slackify to handle parameters that have classes as the type, originally I thought about doing it with a class method (
UserParam.parse(value))But I worried that this would be a bit annoying to people integrating with slackify, so I went with a simple initializer and class attribute intention so that developers can make more custom parsers (such as looking up things externally and returning type errors - not handled yet)