-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update dependencies #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
A-dependencies
Area: Dependencies
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Dec 11, 2022
This MSRV bump is required because the `gethostname` crate has bumped its MSRV to 1.64 in `v0.4.0`.
jarnura
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR performs some dependency updates which have been pending since quite some time.
In addition, this PR removes some of our unused dependencies. @jarnura let me know if any of the dependencies are actually required, I couldn't find any usages of those crates, so I removed them.
The following dependencies are yet to be updated though. If we do update any of these, we end up receiving a
clippy::unreachable
warning, as mentioned in tokio-rs/tracing#2270 (comment).router
's dependencies yet to be updated:actix-cors
aws-config
aws-sdk-kms
reqwest
router_env
's dependencies yet to be updated:tracing
tracing-actix-web
tracing-subscriber
We have four options to address this:
tracing
release.tracing
as a git dependency, which would require us to include backwards incompatible changes meant to go intracing v0.2
.tracing
, backport PR 2356 to thev0.1.x
branch and use it as a git dependency until a new version oftracing
is out.#![allow(clippy::unreachable)]
directive.I'm very much against option 4; a viable solution is option 3 if we must update all dependencies to their latest versions. Let me know what would be preferable according to you.
Motivation and Context
Staying up-to-date.
How did you test it?
Compilation checks using
cargo clippy
andcargo hack check
.Checklist
cargo +nightly fmt
cargo clippy