-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Scenario DSL #139
Merged
Merged
Rewrite Scenario DSL #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 2, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Denire
suggested changes
Feb 9, 2021
core/src/main/kotlin/com/justai/jaicf/model/scenario/Scenario.kt
Outdated
Show resolved
Hide resolved
morfeusys
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change I'd like to see is simplified scenarios in hello-world example that doesn't use Scenario
delegation and also uses activators' type tokens inside actions.
Denire
approved these changes
Mar 9, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old Scenario DSL with the new one in order to support
@DslMarker
There are no major changes in DSL functions, they are the same and work like before.
The changes worth mentioning:
ScenarioBuilder
(orScenario
typealias) because of limitations ofDslMarker
BotEngine
no more requiresScenarioModel
, it requires the object of newScenario
typeScenario
is simply a holder ofScenarioModel
, so users no longer need to doMyScenario.model
Scenario
object. So it's up to the user where to storeScenario
object in order to pass it toBotEngine
.ScenarioBuilder
no longer hasdependencies
parameters,ScenarioModel
no longer hasplus
function. Instead more explicitappend
function were added.ScenarioBuilder#append
is used for append another scenario to the end of this one.Scenario.append
is used to append one scenario to the end of another.append
orhandle
functions. Instead, users have to start scenario building by callingScenarioBuilder#start
function. However, there is com.justai.jaicf.builder.Scenario.kt#startScenario that allows skippingstart
function call, if a user doesn't need to add handlers or append other scenarios.More on creating scenarios:
To create a
Scenario
object a user should simply callScenario
orstartScenario
function.Option 1:
Option 2:
Option 3:
Closes #84
Closes #42