Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rasa model classes #228

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Fix Rasa model classes #228

merged 2 commits into from
Apr 13, 2022

Conversation

nikvoloshin
Copy link
Contributor

Fix RASA NLU model classes in order to conform with API spec

Fixes #227

@Denire
Copy link
Contributor

Denire commented Jan 17, 2022 •
edited
Loading

Maybe we also should set isLenient on kotlinx.serializator for RASA (and maybe other activators or channels using KXS).

serializer = KotlinxSerializer(Json { ignoreUnknownKeys = true; isLenient = true })

This will make serialization less strict

@nikvoloshin nikvoloshin merged commit 32e324a into master Apr 13, 2022
@nikvoloshin nikvoloshin deleted the fix/rasa-model-classes branch April 13, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veptechno veptechno veptechno approved these changes

@Denire Denire Denire approved these changes

@morfeusys morfeusys Awaiting requested review from morfeusys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rasa NLU response parsing error
3 participants
@nikvoloshin @Denire @veptechno