Add transferStatus variable in TelephonyBotRequest #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denire
reviewed
Feb 20, 2023
channels/jaicp/src/main/kotlin/com/justai/jaicf/channel/jaicp/dto/JaicpNativeBotRequest.kt
Outdated
Show resolved
Hide resolved
Denire
approved these changes
Feb 28, 2023
nikvoloshin
approved these changes
Mar 7, 2023
Denire
force-pushed
the
feature/transfer-status
branch
from
7771f4f to
70e1c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
transferStatusvariable has been added to make it easier to describe the settings of thestate("Transfer")in the scenario.Changes:
transferStatusproperty extracts the transfer status from therawRequest.isSuccessproperty to theTransferStatusclass to simplify checking the success of the transfer.