Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

Rails 5 #155

Closed
wants to merge 23 commits into from
Closed

Rails 5 #155

wants to merge 23 commits into from

Conversation

buren
Copy link
Member

@buren buren commented Jan 23, 2016

TODO

@buren buren deployed to just-match-api-staging-pr-155 January 23, 2016 13:40 Active
@@ -3,10 +3,9 @@
# This file contains settings for ActionController::ParamsWrapper which
# is enabled by default.

# Enable parameter wrapping for JSON. You can disable this by setting
# :format to an empty array.
# Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [96/90]

@buren buren deployed to just-match-api-staging-pr-155 January 23, 2016 13:46 Active
@buren buren deployed to just-match-api-staging-pr-155 January 30, 2016 18:28 Active
@buren buren deployed to just-match-api-staging-pr-155 January 30, 2016 18:46 Active
@buren buren deployed to just-match-api-staging-pr-155 February 5, 2016 14:30 Active
@buren buren deployed to just-match-api-staging-pr-155 February 20, 2016 16:47 Active
@@ -0,0 +1,4 @@
# Be sure to restart your server when you modify this file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

@@ -0,0 +1,4 @@
# Be sure to restart your server when you modify this file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

@buren
Copy link
Member Author

buren commented Feb 20, 2016

⚠️ The current built crashes due to some Ruby interpreter bug, so the test suite doesn't really pass!

See https://travis-ci.org/justarrived/just_match_api/builds/110620141#L5393

Seems like there is some issue with the did_you_mean gem.

@buren buren deployed to just-match-api-staging-pr-155 February 21, 2016 22:33 Active
@buren buren deployed to just-match-api-staging-pr-155 February 26, 2016 21:02 Active
@buren buren added the rails 5 label Feb 27, 2016
@buren buren deployed to just-match-api-staging-pr-155 February 28, 2016 19:18 Active
@buren buren closed this Jul 24, 2016
@buren buren removed the in progress label Jul 24, 2016
@buren buren deleted the rails-5 branch December 13, 2016 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants