v0.8.0 added the star icons into a extended class so can be easily reused #17
Conversation
tommaton
requested review from
DamianMullins,
ashleynolan,
kevinrodrigues and
80sgreek
|
|
||
| .c-icon--star--fill, | ||
| %c-icon--star--fill { | ||
| background-image: inline('#{$icon-path}/stars/star--filled.svg'); |
There was a problem hiding this comment.
Where does $icon-path get defined?
There was a problem hiding this comment.
$icon-path is the path thats set in fozzie variables.scss
| @@ -22,3 +22,13 @@ | |||
| height: 42px; | |||
| width: 42px; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Will need CHANGELOG update and package bump otherwise won't be able to release.
(not setup on Travis yet so doesn't catch this as part of the build)
There was a problem hiding this comment.
Suggest that these Fozzie repos get updated with a CONTRIBUTING and a PR template so that these requirements can be found by the uninitiated before opening a PR 😃
There was a problem hiding this comment.
They're usually handled by Travis - we're waiting on InfoSec to approve this to move it public and can then set this up which does these checks automatically. Should be in the next week or so as those tickets have been open for a couple of months.
There was a problem hiding this comment.
Docs to read before doing a PR would be more friendly that being admonished after opening a PR though 😄
There was a problem hiding this comment.
I've added an issue for adding a contributing file to our repos.
There was a problem hiding this comment.
There was a problem hiding this comment.
@martincostello Surely no-one can be angry at fozzie-bot though, even when he's admonishing them 😃
Will make sure we add docs to any repos that need them. @DamianMullins thanks for creating those tickets 👍
No description provided.