Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wc-react18) - added empty react app #293

Merged
merged 16 commits into from
Mar 9, 2023
Merged

feat(wc-react18) - added empty react app #293

merged 16 commits into from
Mar 9, 2023

Conversation

LTurns
Copy link
Contributor

@LTurns LTurns commented Mar 8, 2023

Describe your changes (can list changeset entries if preferable)

[Added] - new empty react app for testing web components
[Added] - examples folder for containing example apps
[Changed] - build script to exclude wc-react18 app

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 02cb69f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the apps label Mar 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

PR Preview Action v1.3.0
🚀 Deployed preview to https://justeattakeaway.github.io/pie/pr-preview-docs/pr-293/
on branch gh-pages at 2023-03-09 14:32 UTC

FayeCarter
FayeCarter previously approved these changes Mar 9, 2023
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@raoufswe raoufswe self-requested a review March 9, 2023 13:00
@LTurns LTurns merged commit badd1f6 into main Mar 9, 2023
@LTurns LTurns deleted the wc-react-example branch March 9, 2023 14:34
@github-actions github-actions bot mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants