cosmetic(pie-docs): use link cards for storybook links #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8243a2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jamieomaguire
added
the
work-in-progress
|
jamieomaguire
added
please review
and removed
work-in-progress
jamieomaguire
force-pushed
the
images-contributing-page
branch
from
7c0f14d to
c9aac58
Compare
FayeCarter
reviewed
Mar 9, 2023
jamieomaguire
force-pushed
the
images-contributing-page
branch
from
84138e6 to
c7fc909
Compare
FayeCarter
approved these changes
Mar 9, 2023
raoufswe
approved these changes
Mar 10, 2023
Merged
FayeCarter
pushed a commit
that referenced
this pull request
Mar 15, 2023
* cosmetic(pie-docs): use link cards for storybook links * fix(pie-docs): use valid aria-hidden attribute values in footer dividers * chore(pie-docs): add changeset file * docs(pie-docs): tweak copy in our-vision page * cosmetic(pie-docs): use higher quality images for storybook cards * cosmetic(pie-docs): add an hr below the new cards * cosmetic(pie-docs): limit label border to image cards * cosmetic(pie-docs): add captioned image to engineers contributing page * chore(pie-docs): add changeset file * refactor(pie-docs): combine hasImage styling under one class modifier for cards * refactor(pie-docs): move card border styling to scss variable * fix(pie-docs): use type/ttf for ptmono preloading type
FayeCarter
added a commit
that referenced
this pull request
Mar 15, 2023
* feat(wc-react18): add pie button to react * feat(wc-react18): add pie-button and styles * docs(pie-docs): content added and amended for the Engineers section of the docs site (#298) * cosmetic(pie-docs): use link cards for storybook links (#299) * cosmetic(pie-docs): use link cards for storybook links * fix(pie-docs): use valid aria-hidden attribute values in footer dividers * chore(pie-docs): add changeset file * docs(pie-docs): tweak copy in our-vision page * cosmetic(pie-docs): use higher quality images for storybook cards * cosmetic(pie-docs): add an hr below the new cards * cosmetic(pie-docs): limit label border to image cards * cosmetic(pie-docs): add captioned image to engineers contributing page * chore(pie-docs): add changeset file * refactor(pie-docs): combine hasImage styling under one class modifier for cards * refactor(pie-docs): move card border styling to scss variable * fix(pie-docs): use type/ttf for ptmono preloading type * Version Packages (#296) release: release packages with 'latest' tag Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * docs(pie-docs): carry out link audit on the docs site (#300) * docs(pie-docs): carry out link audit on the docs site * docs(pie-docs): [Fixed] Small changes from self-review * test(pie-monorepo): added Playwright and new system tests to Pie docs (#294) * test(pie-monorepo): added Playwright and new system tests to Pie docs * ci(pie-monorepo): added npx playwright install * ci(pie-monorepo): updating playwright config for CI * test(pie-docs): update test cookie banner cookies * ci(pie-monorepo): updated build.yml playwright install step * ci(pie-docs): updated cookies domain and path * ci(pie-monorepo): updated playwright install in CI steps * test(pie-docs): updated page routing for tests * ci(pie-monorepo): added reporter upload for CI * test(pie-docs): updated pathName * test(pie-docs): updated baseUrl * ci(pie-monorepo): cache playwright deps * test(pie-monorepo): increase parallel workers to match cpu cores * ci(pie-monorepo): ensure playwright deps get installed after cache restore * ci(pie-monorepo): fix indentation * ci(pie-monorepo): fix indentation v2 * ci(pie-monorepo): fix indentation v3 * test(pie-monorepo): modify test config to reduce duplicate package.json scripts * chore(pie-monorepo): remove dependency * chore(pie-monorepo): update turborepo to allow for passing of root-level args * chore(pie-monorepo): add changeset * fix(pie-monorepo): specify outputs in turbo.json * test(pie-docs): simplify cookie banner tests * format(pie-docs): add comment consistency in tests * format(pie-docs): fix linting * refactor(pie-docs): refactored refresh page in test and addressed comments --------- Co-authored-by: Joshua Ng <[email protected]> Co-authored-by: Ben Siggery <[email protected]> Co-authored-by: Ben Siggery <[email protected]> Co-authored-by: Ben Siggery <[email protected]> * docs(pie-docs): removed line break on 404 page (#289) * docs(pie-docs): removed line break on 404 page * docs(pie-docs): set max-width for centred page text * test(pie-docs): add missing a11y and system tests for docs site 404 page * test(pie-docs): [Fixed] Compare paths for 404-to-homepage test rather than full URL * fix(pie-docs): add missing data-test-id in 404 page * test(pie-docs): refactor test to use playwright * fix(pie-docs): fix test in CI --------- Co-authored-by: Ben Siggery <[email protected]> Co-authored-by: Ben Siggery <[email protected]> * test(pie-docs): 404 test fix (#307) * test(pie-monorepo): added Playwright and new system tests to Pie docs * ci(pie-monorepo): added npx playwright install * ci(pie-monorepo): updating playwright config for CI * test(pie-docs): update test cookie banner cookies * ci(pie-monorepo): updated build.yml playwright install step * ci(pie-docs): updated cookies domain and path * ci(pie-monorepo): updated playwright install in CI steps * test(pie-docs): fix 404 test --------- Co-authored-by: Joshua Ng <[email protected]> Co-authored-by: Ben Siggery <[email protected]> * test(pie-docs): system tests - footer links (#297) * test(pie-docs): new test for footer privacy policy * format(pie-docs): fix linting * test(pie-monorepo): added Playwright and new system tests to Pie docs * ci(pie-monorepo): added npx playwright install * ci(pie-monorepo): updating playwright config for CI * test(pie-docs): update test cookie banner cookies * ci(pie-monorepo): updated build.yml playwright install step * ci(pie-docs): updated cookies domain and path * format(pie-docs): correct variable name * ci(pie-monorepo): updated playwright install in CI steps * test(pie-docs): updated page routing for tests * ci(pie-monorepo): added reporter upload for CI * test(pie-docs): updated pathName * test(pie-docs): updated baseUrl * ci(pie-monorepo): cache playwright deps * test(pie-monorepo): increase parallel workers to match cpu cores * ci(pie-monorepo): ensure playwright deps get installed after cache restore * ci(pie-monorepo): fix indentation * ci(pie-monorepo): fix indentation v2 * ci(pie-monorepo): fix indentation v3 * test(pie-monorepo): modify test config to reduce duplicate package.json scripts * chore(pie-monorepo): remove dependency * chore(pie-monorepo): update turborepo to allow for passing of root-level args * chore(pie-monorepo): add changeset * fix(pie-monorepo): specify outputs in turbo.json * test(pie-docs): simplify cookie banner tests * format(pie-docs): add comment consistency in tests * format(pie-docs): fix linting * test(pie-docs): refactor footer tests to playwright * chore(pie-docs): resolve conflict * chore(pie-docs): solve conflicts * refactor(pie-docs): refactor test --------- Co-authored-by: Ben Siggery <[email protected]> Co-authored-by: Joshua Ng <[email protected]> Co-authored-by: Josh Ng <[email protected]> * test(pie-docs): refactor accessibility tests to use playwright (#302) * test(pie-monorepo): added Playwright and new system tests to Pie docs * ci(pie-monorepo): added npx playwright install * ci(pie-monorepo): updating playwright config for CI * test(pie-docs): update test cookie banner cookies * ci(pie-monorepo): updated build.yml playwright install step * ci(pie-docs): updated cookies domain and path * ci(pie-monorepo): updated playwright install in CI steps * test(pie-docs): refactor accessibility tests to use playwright * format(pie-docs): improve test format * chore(pie-docs): pin deps * chore(pie-docs): update import * format(pie-docs): destructure baseURL to match other tests --------- Co-authored-by: Joshua Ng <[email protected]> Co-authored-by: Ben Siggery <[email protected]> * feat(wc-react18): add custom event * Version Packages (#301) release: release packages with 'latest' tag Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(wc-vue3) - added empty vue 3 app (#311) * feat(wc-vue3) - added empty vue 3 app chore(wc-vue3) - simplified setup chore(wc-vue3) - updated yarn.lock chore(wc-vue3) - added eslint config * chore(wc-vue3) - changeset * chore(wc-vue3) - remove unnecessary vue plugin * test(pie-docs): updated visual tests to support playwright (#312) * test(pie-monorepo): added Playwright and new system tests to Pie docs * test(pie-docs): update test cookie banner cookies * ci(pie-docs): updated cookies domain and path * test(pie-docs): refactor accessibility tests to use playwright * test(pie-docs): added percy playwright integration * wip: add custom fixture * refactor(pie-docs): ensure visual tests use playwright * test(pie-docs): updated visual tests to support playwright * fix(pie-docs): re-added babel config * refactor(pie-docs): remove comment from babel config * performance(pie-docs): updated playwright workers * chore(pie-monorepo): rebase * chore(pie-monorepo): removed already versioned changesets * chore(pie-monorepo): addressed PR comments * chore(pie-monorepo): addressed PR comments * chore(pie-docs): grammar --------- Co-authored-by: Joshua Ng <[email protected]> Co-authored-by: siggerzz <[email protected]> Co-authored-by: Ben Siggery <[email protected]> * docs(pie-docs): remove our vision engineers page and update roadmap (#315) * docs(pie-docs): remove our vision engineers page and update roadmap * test(pie-docs): remove test route * docs(pie-docs): updated support section copy (#316) * docs(pie-docs): update home page copy (#317) * docs(pie-docs): copy updates to what is pie and our vision (#318) * docs(pie-docs): copy updates to what is pie and our vision * cosmetic(pie-docs): add ? to What is PIE nav key * feat(wc-react18): remove ^ * feat(wc-react18): add changesets * feat(wc-react18): update readme * Update README.md * Update README.md * chore(wc-react18): add custom eslint settings enabling React parsing * feat(wc-react18): update from review comments * fix(wc-react18): load fonts using a link tag * chore(wc-react18): use dev to start server * chore(wc-react18): add volta settings to package.json --------- Co-authored-by: Ashley Watson-Nolan <[email protected]> Co-authored-by: Jamie Maguire <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Xander Marjoram <[email protected]> Co-authored-by: Josh Ng <[email protected]> Co-authored-by: Joshua Ng <[email protected]> Co-authored-by: Ben Siggery <[email protected]> Co-authored-by: Ben Siggery <[email protected]> Co-authored-by: Ben Siggery <[email protected]> Co-authored-by: Fernando de França <[email protected]> Co-authored-by: Raouf <[email protected]> Co-authored-by: Raouf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
[Changed] - Use cards for storybook links on the engineers contributing page
[Changed] - Minor copy updates to engineer pages and correct aria-hidden usage in footer
[Changed] - Use
font/ttffor preload type for PTMono font as `font/truetype' is invalidAuthor Checklist (complete before requesting a review)
PIE Docschange, I have reviewed the PR previewReviewer checklists (complete before approving)
Reviewer 1
PIE Docschange, I have reviewed the PR previewReviewer 2
PIE Docschange, I have reviewed the PR preview