Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package.json > engines > nodeを更新しない #142

Merged
merged 1 commit into from
May 30, 2024

Conversation

kondei
Copy link
Contributor

@kondei kondei commented May 30, 2024

Description

renovateにpackage.json > engines > nodeを更新させない

Reason

20.x のような指定をrenovateが 20.13.1 のような指定に変えてしまうことでvercelとバージョン乖離してビルドが落ちることが多い
(かといって ^20.13.1 のようなキャレット付きで最新にし続けるとvercelがバージョンを巻き戻したときにビルドエラーになったのでそれはできない)
のでrenovateに無視させるため

https://justincase-team.slack.com/archives/C02R5F3NB25/p1716177053383089?thread_ts=1715910947.749409&cid=C02R5F3NB25

Document URL

参考: renovatebot/renovate#13521

@kondei kondei requested a review from a team as a code owner May 30, 2024 04:29
@kondei kondei requested review from takkyun and nonsugarless May 30, 2024 04:29
@kondei kondei merged commit 3758b99 into main May 30, 2024
4 checks passed
@kondei kondei deleted the ignore-engines-node branch May 30, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants