shotover#1650 Add tests

shotover-proxy/tests/redis_int_tests/mod.rs

@@ -12,6 +12,7 @@ use std::thread::sleep;
 use std::time::Duration;
 use test_helpers::connection::redis_connection;
 use test_helpers::docker_compose::docker_compose;
+use test_helpers::metrics::assert_metrics_key_value;
 use test_helpers::shotover_process::{Count, EventMatcher, Level};
 
 pub mod assert;
@@ -321,3 +322,54 @@ async fn cluster_dr() {
 
     shotover.shutdown_and_then_consume_events(&[]).await;
 }
+
+#[tokio::test(flavor = "multi_thread")]
+async fn test_failed_requests_metric_sink_single() {
+    let _compose = docker_compose("tests/test-configs/redis/passthrough/docker-compose.yaml");
+    let shotover = shotover_process("tests/test-configs/redis/passthrough/topology.yaml")
+        .start()
+        .await;
+    let mut connection = redis_connection::new_async("127.0.0.1", 6379).await;
+
+    redis::cmd("INVALID_COMMAND")
+        .arg("foo")
+        .query_async::<_, ()>(&mut connection)
+        .await
+        .unwrap_err();
+
+    // Redis client driver initialization sends 2 CLIENT SETINFO commands which trigger 2 errors
+    // because those commands are not available in the currently used redis version.
+    assert_metrics_key_value(
+        r#"shotover_failed_requests_count{chain="redis",transform="RedisSinkSingle"}"#,
+        "3",
+    )
+    .await;
+
+    shotover.shutdown_and_then_consume_events(&[]).await;
+}
+
+#[tokio::test(flavor = "multi_thread")]
+async fn test_failed_requests_metric_sink_cluster() {
+    let _compose = docker_compose("tests/test-configs/redis/cluster-handling/docker-compose.yaml");
+    let shotover = shotover_process("tests/test-configs/redis/cluster-handling/topology.yaml")
+        .start()
+        .await;
+
+    let mut connection = redis_connection::new_async("127.0.0.1", 6379).await;
+
+    redis::cmd("INVALID_COMMAND")
+        .arg("foo")
+        .query_async::<_, ()>(&mut connection)
+        .await
+        .unwrap_err();
+
+    // Redis client driver initialization sends 2 CLIENT SETINFO commands which trigger 2 errors
+    // because those commands are not available in the currently used redis version.
+    assert_metrics_key_value(
+        r#"shotover_failed_requests_count{chain="redis",transform="RedisSinkCluster"}"#,
+        "3",
+    )
+    .await;
+
+    shotover.shutdown_and_then_consume_events(&[]).await;
+}

shotover/src/transforms/redis/sink_cluster.rs

@@ -102,16 +102,13 @@ impl RedisSinkClusterBuilder {
         chain_name: String,
         shared_topology: Arc<RwLock<Topology>>,
     ) -> Self {
-        let failed_requests =
-            counter!("shotover_failed_requests_count", "chain" => chain_name, "transform" => NAME);
-
         RedisSinkClusterBuilder {
             first_contact_points,
             direct_destination,
             connection_count,
             connection_pool,
             shared_topology,
-            failed_requests,
+            failed_requests: counter!("shotover_failed_requests_count", "chain" => chain_name, "transform" => NAME),
         }
     }
 }