Lots of stuff #11
Open
Lots of stuff #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headless chrome on the fly)
added: injectPure, injectEffect
added: free variable detection in `extractDefinitions`
|
Could you move the browserify based unsafe eval into a separate module and then just require it at the top level there? I do not want to use it personally, but if it's usable enough, it would be better to have it in a separate module that can be imported on purpose. It would also be good to name it something sufficiently different from the unsafe string eval, since it goes through a large process. Even "evalViaBrowserify" or something would be fine in such a case. |
justinwoo
reviewed
Jul 23, 2019
removed unused types
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that that hack of mine still works as of 0.13.
Sorry for the awful state of the PR, just please tell me what parts of it do you agree to include, and I'll cherry-pick them.