Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

summarizeNote() method dropped in 146f9b537a4157e1522d6a2b485e9d2aec194c1e #19

Closed
NeilHanlon opened this issue Mar 1, 2024 · 2 comments
Closed

summarizeNote() method dropped in 146f9b537a4157e1522d6a2b485e9d2aec194c1e #19

NeilHanlon opened this issue Mar 1, 2024 · 2 comments

Comments

@NeilHanlon
Copy link

146f9b5
@NeilHanlon
Copy link
Author 

An exception was thrown as a result of invoking function summarizeNote error: summarizeNote is not defined
(anonymous) @ silverbullet-ai.plug.js:1
await in (anonymous) (async)
(anonymous) @ silverbullet-ai.plug.js:1

@justyns justyns closed this as completed in f254386 Mar 6, 2024
justyns added a commit that referenced this issue Mar 6, 2024
@justyns
Merge pull request #24 from justyns/re-add-summary
9155019 
Re-add summarizeNote and insertSummary commands, fixes #19.  Also add non-streaming support to gemini
@justyns
Copy link
Owner

justyns commented Mar 6, 2024

Thanks for reporting this! It should be fixed in main in a few minutes.

I realized my intention was to get rid of these summary functions, but not yet. I want to provide an easier way to do the same thing using templated prompts instead of having built-in hardcoded prompts like its using now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justyns @NeilHanlon