Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] - Support dependencies in modules #27

Closed
wants to merge 13 commits into from
Prev Previous commit
Next Next commit
removes logs
  • Loading branch information
karimMourra committed May 13, 2022
commit 3ccc5e2dba432ef728a72b0ff8f7c8440b003508
2 changes: 1 addition & 1 deletion modules/jwplayerVideoProvider.js
Original file line number Diff line number Diff line change
@@ -193,7 +193,7 @@ export function JWPlayerProvider(config, jwplayer_, adState_, timeState_, callba

function offEvents(events, callback) {
events.forEach(event => {
const jwEvent = utils.getJwEvent(event, prebidVideoEvents);
const jwEvent = utils.getJwEvent(event);
if (!callback) {
player.off(jwEvent);
return;
7 changes: 3 additions & 4 deletions modules/testVideoProvider.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import {
PROTOCOLS, API_FRAMEWORKS, VIDEO_MIME_TYPE, PLAYBACK_METHODS, PLACEMENT, VPAID_MIME_TYPE
} from './videoModule/constants/ortb.js';
import { PLAYBACK_MODE } from './videoModule/constants/enums.js';
import {
SETUP_COMPLETE, SETUP_FAILED, DESTROYED, AD_REQUEST, AD_BREAK_START, AD_LOADED, AD_STARTED, AD_IMPRESSION, AD_PLAY,
AD_TIME, AD_PAUSE, AD_CLICK, AD_SKIPPED, AD_ERROR, AD_COMPLETE, AD_BREAK_END, PLAYLIST, PLAYBACK_REQUEST,
AUTOSTART_BLOCKED, PLAY_ATTEMPT_FAILED, CONTENT_LOADED, PLAY, PAUSE, BUFFER, TIME, SEEK_START, SEEK_END, MUTE, VOLUME,
RENDITION_UPDATE, ERROR, COMPLETE, PLAYLIST_COMPLETE, FULLSCREEN, PLAYER_RESIZE, VIEWABLE, CAST, PLAYBACK_MODE
RENDITION_UPDATE, ERROR, COMPLETE, PLAYLIST_COMPLETE, FULLSCREEN, PLAYER_RESIZE, VIEWABLE, CAST
} from './videoModule/constants/events.js';
import stateFactory from './videoModule/shared/state.js';
import { VIDEO_JS_VENDOR } from './videoModule/constants/vendorCodes.js';
@@ -17,11 +18,9 @@ export function testProvider() {
state.updateState(PROTOCOLS, API_FRAMEWORKS, VIDEO_MIME_TYPE, PLAYBACK_METHODS, PLACEMENT, VPAID_MIME_TYPE, SETUP_COMPLETE, SETUP_FAILED, DESTROYED, AD_REQUEST, AD_BREAK_START, AD_LOADED, AD_STARTED, AD_IMPRESSION, AD_PLAY,
AD_TIME, AD_PAUSE, AD_CLICK, AD_SKIPPED, AD_ERROR, AD_COMPLETE, AD_BREAK_END, PLAYLIST, PLAYBACK_REQUEST,
AUTOSTART_BLOCKED, PLAY_ATTEMPT_FAILED, CONTENT_LOADED, PLAY, PAUSE, BUFFER, TIME, SEEK_START, SEEK_END, MUTE, VOLUME,
RENDITION_UPDATE, ERROR, COMPLETE, PLAYLIST_COMPLETE, FULLSCREEN, PLAYER_RESIZE, VIEWABLE, CAST);
RENDITION_UPDATE, ERROR, COMPLETE, PLAYLIST_COMPLETE, FULLSCREEN, PLAYER_RESIZE, VIEWABLE, CAST, registerBidder, PLAYBACK_MODE);
}

console.log(registerBidder);

testProvider.code = VIDEO_JS_VENDOR;

submodule('videoModule', testProvider);
1 change: 0 additions & 1 deletion webpack.conf.js
Original file line number Diff line number Diff line change
@@ -49,7 +49,6 @@ module.exports = {
}
}
});
console.log(entry);
return entry;
})(),
output: {