feat(videodetail): set share button conditional to config

jwplayer · Jun 14, 2021 · 322b1fe · 322b1fe
1 parent 7d96945
commit 322b1fe
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 9 deletions.
diff --git a/src/components/Button/Button.module.scss b/src/components/Button/Button.module.scss
@@ -75,5 +75,9 @@
     height: 20px;
     width: 20px;
     fill: currentColor;
+    @include responsive.tablet-only() {
+      width: 18px;
+      height: 18px;
+    }
   }
 }
diff --git a/src/components/Video/Video.module.scss b/src/components/Video/Video.module.scss
@@ -62,9 +62,10 @@
 .otherButtons {
   display: flex;
   justify-content: center;
+  width: 100%;
   > button {
     margin-right: 8px;
-    width: 33%;
+    width: 100%;
   }
   > button:last-child {
     margin-right: 0px;
@@ -74,7 +75,6 @@
     > button:first-child {
       margin-bottom: 8px;
       margin-right: 0px;
-      width: 100%;
     }
     > button:not(:first-child) {
       flex: 1;

diff --git a/src/components/Video/Video.test.tsx b/src/components/Video/Video.test.tsx
@@ -32,6 +32,7 @@ describe('<Video>', () => {
         play
         hasShared={false}
         onShareClick={() => null}
+        enableSharing
       />,
     );
 

diff --git a/src/components/Video/Video.tsx b/src/components/Video/Video.tsx
@@ -26,6 +26,7 @@ type Props = {
   startPlay: () => void;
   goBack: () => void;
   poster: Poster;
+  enableSharing: boolean;
   hasShared: boolean;
   onShareClick: () => void;
   relatedShelf?: JSX.Element;
@@ -37,6 +38,7 @@ const Video: React.FC<Props> = ({
   startPlay,
   goBack,
   poster,
+  enableSharing,
   hasShared,
   onShareClick,
   relatedShelf,
@@ -90,12 +92,14 @@ const Video: React.FC<Props> = ({
               fullWidth={breakpoint < Breakpoint.sm}
             />
             <Button label={t('video:favorite')} startIcon={<Favorite />} onClick={() => null} />
-            <Button
-              label={hasShared ? t('video:copied_url') : t('video:share')}
-              startIcon={hasShared ? <Check /> : <Share />}
-              onClick={onShareClick}
-              active={hasShared}
-            />
+            {enableSharing && (
+              <Button
+                label={hasShared ? t('video:copied_url') : t('video:share')}
+                startIcon={hasShared ? <Check /> : <Share />}
+                onClick={onShareClick}
+                active={hasShared}
+              />
+            )}
           </div>
         </div>
         <div

diff --git a/src/containers/Video/Video.tsx b/src/containers/Video/Video.tsx
@@ -26,7 +26,8 @@ const Video = ({ playlistId, videoType, episodeId, mediaId }: VideoProps): JSX.E
   const play = new URLSearchParams(location.search).get('play') === '1';
   const config: Config = useContext(ConfigContext);
   const [hasShared, setHasShared] = useState<boolean>(false);
-  const posterFading: boolean = config ? config.options.posterFading === true : false;
+  const enableSharing: boolean = config.options.enableSharing === true;
+  const posterFading: boolean = config.options.posterFading === true;
 
   const { isLoading, error, data: { playlist } = { playlist: [] } } = usePlaylist(playlistId);
 
@@ -69,6 +70,7 @@ const Video = ({ playlistId, videoType, episodeId, mediaId }: VideoProps): JSX.E
       startPlay={startPlay}
       goBack={goBack}
       poster={posterFading ? 'fading' : 'normal'}
+      enableSharing={enableSharing}
       hasShared={hasShared}
       onShareClick={onShareClick}
       relatedShelf={
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,6 +32,7 @@ describe('<Video>', () => { @@
             play
             hasShared={false}
             onShareClick={() => null}
+            enableSharing
           />,
         );
@@ Expand Down @@