fix(project): fix snowpack optimize using webpack

jwplayer · Jun 3, 2021 · 4a2883f · 4a2883f
1 parent 7c60d52
commit 4a2883f
Show file tree

Hide file tree

Showing 3 changed files with 494 additions and 87 deletions.
diff --git a/public/index.html b/public/index.html
@@ -30,7 +30,6 @@
 <body>
 <div id="root"></div>
 <noscript>You need to enable JavaScript to run this app.</noscript>
-<script type="module" src="/dist/index.js"></script>
 <script>
   var urlSearchParams = new URLSearchParams(window.location.search);
   var configId =
@@ -46,6 +45,7 @@
     window.configLocation = './config.json';
   }
 </script>
+<script type="module" src="/dist/index.js"></script>
 <!--
   This HTML file is a template.
   If you open it directly in the browser, you will see an empty page.

diff --git a/snowpack.config.js b/snowpack.config.js
@@ -15,33 +15,33 @@ module.exports = {
     '@snowpack/plugin-react-refresh',
     '@snowpack/plugin-dotenv',
     '@snowpack/plugin-sass',
-    // ['@snowpack/plugin-webpack', {
-    //   extendConfig: (config) => {
-    //     // FIXES https://github.com/snowpackjs/snowpack/discussions/2810
-    //     config.module.rules.find(
-    //       (rule) =>
-    //         rule &&
-    //         rule.use &&
-    //         rule.use.find((use) => {
-    //           if (
-    //             !use ||
-    //             !use.loader ||
-    //             !use.loader.includes('babel-loader')
-    //           ) {
-    //             return null;
-    //           }
-    //
-    //           use.options.plugins = (use.options.plugins || []).concat([
-    //             '@babel/plugin-proposal-optional-chaining',
-    //             '@babel/plugin-proposal-nullish-coalescing-operator'
-    //           ]);
-    //
-    //           return use;
-    //         }),
-    //     );
-    //     return config;
-    //   },
-    // }],
+    ['@snowpack/plugin-webpack', {
+      extendConfig: (config) => {
+        // FIXES https://github.com/snowpackjs/snowpack/discussions/2810
+        const babelRule = config.module.rules.find((rule) =>
+          rule && rule.use && rule.use.find((use) => use && use.loader && use.loader.includes('babel-loader')));
+
+        if (babelRule) {
+          babelRule.use = babelRule.use.filter(use => {
+            if (use.loader.includes('babel-loader')) {
+              use.options.plugins = (use.options.plugins || []).concat([
+                '@babel/plugin-proposal-optional-chaining',
+                '@babel/plugin-proposal-nullish-coalescing-operator'
+              ]);
+            }
+
+            // filter out proxy-import-resolve
+            if (use.loader.includes('proxy-import-resolve')) {
+              return false;
+            }
+
+            return true;
+          });
+        }
+
+        return config;
+      },
+    }],
     [
       '@snowpack/plugin-typescript',
       {