feat(project): add nullable as values for colors

jwplayer · May 6, 2021 · 9a3cc67 · 9a3cc67
1 parent 13d81f0
commit 9a3cc67
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/services/config.service.ts b/src/services/config.service.ts
@@ -16,8 +16,8 @@ const menuSchema: SchemaOf<Menu> = object().shape({
 });
 
 const optionsSchema: SchemaOf<Options> = object({
-  backgroundColor: string().notRequired(),
-  highlightColor: string().notRequired(),
+  backgroundColor: string().nullable(),
+  highlightColor: string().nullable(),
   enableContinueWatching: boolean().notRequired(),
   headerBackground: string().notRequired(),
   enableCasting: boolean().notRequired(),
@@ -86,6 +86,7 @@ const serializeDeprecatedConfig = (config: Config) => {
     analyticsToken: description.analyticsToken,
     options: {
       dynamicBlur: description.dynamicBlur,
+      ...config.options,
     },
   };
   console.info(newConfig);

diff --git a/types/Config.d.ts b/types/Config.d.ts
@@ -35,8 +35,8 @@ export type Menu = {
 };
 
 export type Options = {
-  backgroundColor?: string;
-  highlightColor?: string;
+  backgroundColor?: string | null;
+  highlightColor?: string | null;
   enableContinueWatching?: boolean;
   headerBackground?: string;
   enableCasting?: boolean;