feat(project): add aria properties to header

jwplayer · Apr 30, 2021 · df53f63 · df53f63
1 parent 088254f
commit df53f63
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/components/Header/Header.tsx b/src/components/Header/Header.tsx
@@ -21,11 +21,13 @@ const Header: React.FC<Props> = ({ headerType = 'static', openSideBar }) => {
         <div
           className={styles.menu}
           onClick={(sideBarOpen) => openSideBar(!sideBarOpen)}
+          aria-label="open menu"
+          role="button"
         >
           <Menu />
         </div>
         <Logo src="https://cdn.jwplayer.com/images/HXyBCU5N.png" />
-        <nav className={styles.nav}>
+        <nav className={styles.nav} aria-label="menu">
           <ButtonLink label="Home" to="/" />
           {/* mock */}
           <ButtonLink label="Playlist" to="/p/:id" />

diff --git a/src/components/Header/__snapshots__/Header.test.tsx.snap b/src/components/Header/__snapshots__/Header.test.tsx.snap
@@ -9,10 +9,14 @@ exports[`<Header /> renders header 1`] = `
       class="container"
     >
       <div
+        aria-label="open menu"
         class="menu"
+        role="button"
       >
         <svg
+          aria-hidden="true"
           class="icon"
+          focusable="false"
           viewBox="0 0 24 24"
           xmlns="http://www.w3.org/2000/svg"
         >
@@ -37,6 +41,7 @@ exports[`<Header /> renders header 1`] = `
         />
       </div>
       <nav
+        aria-label="menu"
         class="nav"
       >
         <a