Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user): missing isCommon error check #403

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

kiremitrov123
Copy link
Collaborator

Description

Somehow this condition got deleted during a merge.

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

Visit the preview URL for this PR (updated for commit d8b946a):

https://ottwebapp--pr403-fix-missing-common-e-xxo0752l.web.app

(expires Sun, 17 Dec 2023 11:10:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@kiremitrov123 kiremitrov123 merged commit 5e2ce14 into develop Nov 17, 2023
9 checks passed
@kiremitrov123 kiremitrov123 deleted the fix/missing-common-error-check branch November 17, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants