Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(series): add empty media items filter #415

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

AntonLantukh
Copy link
Collaborator

Description

  • Unpublished episodes are returned as null, we need to filter these items.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Dec 5, 2023

Visit the preview URL for this PR (updated for commit 14b0019):

https://ottwebapp--pr415-fix-filter-empty-epi-p59g38tc.web.app

(expires Fri, 05 Jan 2024 16:37:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@AntonLantukh AntonLantukh force-pushed the fix/filter-empty-episodes branch from 3010224 to d765cd2 Compare December 5, 2023 19:30
@AntonLantukh AntonLantukh requested a review from dbudzins December 5, 2023 19:40
@AntonLantukh AntonLantukh requested a review from dbudzins December 6, 2023 16:50
@AntonLantukh AntonLantukh merged commit c47ca66 into develop Dec 8, 2023
9 checks passed
@AntonLantukh AntonLantukh deleted the fix/filter-empty-episodes branch December 8, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants