Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate - v6.0.0 #467

Closed
wants to merge 77 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
a95c3a3
chore: merge release to develop
dbudzins Jan 24, 2024
3e3e2b1
feat(project)!: restructure for multiplatforms with workspaces (#435)
ChristiaanScheermeijer Jan 31, 2024
6babace
feat(project): dynamic gtm snippet
langemike Jan 24, 2024
8c0cb9a
refactor(project): make route definitions static and improve url utils
royschut Jan 24, 2024
1612002
refactor: refactor typings
ChristiaanScheermeijer Jan 24, 2024
588f69a
fix(auth): capture error to prevent misleading “wrong combination” error
langemike Jan 25, 2024
9d8ff15
feat(project): customizable footer through env-var
langemike Jan 25, 2024
f98e99c
refactor(project): add replaceable components to ui-react
royschut Jan 25, 2024
a1c6188
feat(project): favicons in different sizes
langemike Jan 26, 2024
1e3607d
chore(project): dynamic manifest.json
langemike Jan 26, 2024
bcfb08b
chore: update depcheck
ChristiaanScheermeijer Jan 30, 2024
bb593e9
fix(player): inlineplayer not supporting tvod
royschut Jan 25, 2024
7de84ae
fix(user): tvod subscription not reloaded after login for authvod/avod
royschut Jan 25, 2024
3c021a9
refactor(payment): fix hasTVODOffers not properly defined
royschut Jan 25, 2024
7b483b9
docs(project): update url signing link
royschut Jan 25, 2024
d63b056
fix(payment): subscription offer panel shown for authvod+tvod
royschut Jan 25, 2024
626fa6b
refactor(payment): simplify useOffers hook
royschut Jan 25, 2024
7bba6a2
refactor(user): prevent unnecessary subscription calls
royschut Jan 26, 2024
5dc0a18
refactor(user): let reloadSubscriptions handle all access modals
royschut Jan 30, 2024
710694d
refactor: Cleeng and Inplayer account typings
ChristiaanScheermeijer Jan 30, 2024
6503267
fix(project): show footer when custom footer is provided
langemike Feb 5, 2024
b299bb7
fix/checkout bugs
royschut Feb 5, 2024
a2885eb
fix(account): delete account error
ChristiaanScheermeijer Feb 5, 2024
dbecda4
refactor: move controllers and refactor form logic
royschut Feb 1, 2024
3deabfc
fix: favorites and history validation error
ChristiaanScheermeijer Feb 6, 2024
ca71f29
fix(payment): redirect after incorrect couponcode entry
royschut Feb 6, 2024
d01d1b7
fix(payment): tvod offer not showing in AuthVOD platform
royschut Feb 6, 2024
c97c59b
fix(payment): incorrect couponCode success message
royschut Feb 6, 2024
320fe44
fix: root error screen for unexpected errors
ChristiaanScheermeijer Feb 7, 2024
ca3d38e
fix(project): undouble serieIds to prevent crash
langemike Feb 7, 2024
86b461f
fix: hide start watching button in avod platform
ChristiaanScheermeijer Feb 7, 2024
b700fbb
fix: e2e test optimisations and small fixes
langemike Feb 8, 2024
ac444bd
refactor: revisit login and register try catch flow
ChristiaanScheermeijer Feb 9, 2024
24dde0b
refactor: move form validation error and pass all errors
ChristiaanScheermeijer Feb 9, 2024
9266111
refactor: add loading state for publisher consents
ChristiaanScheermeijer Feb 9, 2024
0837944
fix: set wrong loading state in early return
ChristiaanScheermeijer Feb 9, 2024
bf3e5b5
fix: update order error handling
ChristiaanScheermeijer Feb 9, 2024
7119a79
refactor: simplify path constants
ChristiaanScheermeijer Feb 9, 2024
ff28a07
refactor: use keyed object in submit paypal method
ChristiaanScheermeijer Feb 9, 2024
5e1e84a
chore: revert config footer text removal
ChristiaanScheermeijer Feb 12, 2024
dd8d484
refactor: render error to component
ChristiaanScheermeijer Feb 20, 2024
3fdb220
fix: restore personal shelves after registration
ChristiaanScheermeijer Feb 20, 2024
2741eac
fix: personal shelves restoration
ChristiaanScheermeijer Feb 20, 2024
7ace580
Merge pull request #450 from jwplayer/feat/small-features-and-refacto…
AntonLantukh Feb 21, 2024
cc02259
feat(a11y): many accessibility optimisations
langemike Jan 24, 2024
8a5ad86
fix(project): create missing pwa icons
langemike Feb 5, 2024
6444282
feat(a11y): update font colors for contrast and adjust active state i…
MelissaDTH Feb 5, 2024
b3ccaff
fix(a11y): prevent duplicate global a11y selectors
ChristiaanScheermeijer Feb 5, 2024
91dc66c
fix(a11y): shelf item navigation with screen reader
langemike Feb 5, 2024
92c2675
chore: update snapshots
ChristiaanScheermeijer Feb 6, 2024
ddcfc91
fix: language menu icon not centered
ChristiaanScheermeijer Feb 5, 2024
5fe1665
fix(a11y): remove outline when user is not tabbing
ChristiaanScheermeijer Feb 5, 2024
aef1415
fix(a11y): format date call caused an error to be raised
langemike Feb 6, 2024
ea4af42
fix(menu): ensure logo does not exceed width of the header
MelissaDTH Feb 6, 2024
e50807b
refactor(a11y): remove double account header and add translations
MelissaDTH Feb 7, 2024
b4c3230
fix(a11y): constrast enhancement for search field
langemike Feb 7, 2024
1d2f25f
feat: underline for active header item and add lineair gradient
MelissaDTH Feb 8, 2024
1791b4c
fix: enter key not closing the account modal
ChristiaanScheermeijer Feb 7, 2024
a0cca10
fix: logo and header layout issues
ChristiaanScheermeijer Feb 7, 2024
7a14497
fix(a11y): close search bar when pressing escape
ChristiaanScheermeijer Feb 7, 2024
c4d09c5
fix: e2e tests for a11y
langemike Feb 8, 2024
361c58a
fix: related videos title layout issue
ChristiaanScheermeijer Feb 21, 2024
bf79d10
fix: footer overlap fix
ChristiaanScheermeijer Feb 21, 2024
2ded57b
fix: click not working in layout grid
ChristiaanScheermeijer Feb 21, 2024
85c2aaf
refactor: remove reactive focus from layout grid
ChristiaanScheermeijer Feb 22, 2024
a6305ef
fix: layout grid home and page down problem
ChristiaanScheermeijer Feb 22, 2024
6a291a7
fix: layout grid arrow down and end problem
ChristiaanScheermeijer Feb 22, 2024
69eff3c
fix(project): fix live stream duration check for ott plugin (#460)
AntonLantukh Mar 14, 2024
82b5967
feat: accessibility improvements and bug fixes
ChristiaanScheermeijer Mar 15, 2024
d7db57a
feat(watchhistory): change max items limit (#418)
AntonLantukh Mar 18, 2024
d37905d
feat(payment): disable deprecated receipts cleeng (#458)
royschut Mar 18, 2024
3da156c
chore: replace depcheck with knip (#462)
dbudzins Mar 19, 2024
b65bade
docs(project): update docs for workspaces
ChristiaanScheermeijer Jan 25, 2024
4faaeef
docs: spellcheck and fix feedback
ChristiaanScheermeijer Mar 19, 2024
0a9817a
feat(project): update default content-type schemas
AntonLantukh Mar 18, 2024
72325a6
fix(project): unused dep
AntonLantukh Mar 21, 2024
5678d43
chore(release): v6.0.0
invalid-email-address Mar 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .commitlintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ module.exports = {
'user',
'watchhistory',
'favorites',
'profiles',
'analytics',
'pwa',
'seo',
Expand All @@ -29,6 +30,7 @@ module.exports = {
'epg',
'tests',
'i18n',
'a11y',
],
],
},
Expand Down
30 changes: 0 additions & 30 deletions .depcheckrc.yaml

This file was deleted.

8 changes: 0 additions & 8 deletions .env

This file was deleted.

6 changes: 2 additions & 4 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Modules
node_modules/

# Test
coverage/

# Build output
build/

coverage/
128 changes: 1 addition & 127 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,129 +1,3 @@
const restrictedGlobals = require('confusing-browser-globals');

module.exports = {
parser: '@typescript-eslint/parser',

plugins: [
// Enable Typescript linting
'@typescript-eslint',

// Enable linting imports
'import',
],

extends: [
// Use default ESLint rules
'eslint:recommended',

// Use recommended TS rules
'plugin:@typescript-eslint/recommended',

// Use recommended React rules
'plugin:react/recommended',

'plugin:import/errors',
'plugin:import/warnings',
'plugin:import/typescript',
],

env: {
// Browser conf
browser: true,
es6: true,
},

rules: {
// Prevent development/debugging statements
'no-console': ['error', { allow: ['warn', 'error', 'info', 'debug'] }],
'no-alert': 'error',
'no-debugger': 'error',

// Prevent usage of confusing globals
'no-restricted-globals': ['error'].concat(restrictedGlobals),

// Assignments in function returns is confusing and could lead to unwanted side-effects
'no-return-assign': ['error', 'always'],

curly: ['error', 'multi-line'],

// Strict import ordering
'import/order': [
'warn',
{
groups: ['builtin', 'external', 'parent', 'sibling', 'index'],
pathGroups: [
// Sort absolute root imports before parent imports
{
pattern: '/**',
group: 'parent',
position: 'before',
},
],
'newlines-between': 'always',
},
],
// Not needed in React 17
'react/react-in-jsx-scope': 'off',
'import/no-named-as-default-member': 'off',
},
overrides: [
{
files: ['*.js'],
env: {
// We may still use CJS in .js files (eg. local scripts)
commonjs: true,
},
rules: {
// `require` is still allowed/recommended in JS
'@typescript-eslint/no-var-requires': 'off',
},
},
{
files: ['*.ts', '*.tsx'],
rules: {
// TypeScript 4.0 adds 'any' or 'unknown' type annotation on catch clause variables.
// We need to make sure error is of the type we are expecting
'@typescript-eslint/no-implicit-any-catch': 'error',

// These are handled by TS
'@typescript-eslint/no-explicit-any': ['warn', { ignoreRestArgs: true }],
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-inferrable-types': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
'@typescript-eslint/no-unused-vars': 'off',
'import/no-unresolved': 'off',
},
},
{
files: ['*.jsx', '*.tsx', 'src/hooks/*.ts'],
plugins: [
// Enable linting React code
'react',
'react-hooks',
],
rules: {
// Help with Hooks syntax
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'error',

// Handled by Typescript
'react/prop-types': 'off',

// This rule causes too many false positives, eg. with default exports or child render function
'react/display-name': 'off',
},
},
],

settings: {
react: {
pragma: 'React',
version: '17',
},
},
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
extends: ['jwp/typescript'],
};
3 changes: 2 additions & 1 deletion .github/workflows/release-build-tag-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
echo "current-version=${version}" >> "$GITHUB_OUTPUT"

- name: Build App
working-directory: ./platforms/web
run: |
yarn build
cd build
Expand Down Expand Up @@ -51,7 +52,7 @@ jobs:
if: ${{ steps.package-version.outputs.current-version }}
with:
commit: 'release'
artifacts: 'build/ott-web-app-build-*.tar.gz, build/ott-web-app-build-*.zip'
artifacts: 'web/build/ott-web-app-build-*.tar.gz, web/build/ott-web-app-build-*.zip'
tag: v${{ steps.package-version.outputs.current-version }}
bodyFile: '.github/RELEASE_BODY_TEMPLATE.md'
token: ${{ secrets.github_token }}
22 changes: 0 additions & 22 deletions .github/workflows/release-deploy-prod-demo.yml

This file was deleted.

44 changes: 0 additions & 44 deletions .github/workflows/test-e2e.yml

This file was deleted.

34 changes: 0 additions & 34 deletions .github/workflows/test-preview-and-lighthouse.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/test-unit-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: yarn install, build, and test
- name: yarn install and test
run: |
yarn
yarn test
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/web-release-deploy-prod-demo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Web - Release - Deploy Prod Demo Site

on:
push:
branches: ['release']
workflow_dispatch:

defaults:
run:
working-directory: ./platforms/web

jobs:
deploy_live_website:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Build
env:
APP_PLAYER_LICENSE_KEY: ${{ secrets.PLAYER_LICENSE_KEY }}
APP_GOOGLE_SITE_VERIFICATION_ID: ${{ vars.GOOGLE_SITE_VERIFICATION_ID }}
run: yarn && MODE=demo yarn build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
channelId: live
entryPoint: './platforms/web'
39 changes: 39 additions & 0 deletions .github/workflows/web-test-deploy-preview-and-lighthouse.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Web - Test - PR Deploy Preview and Lighthouse Test

on:
pull_request:

defaults:
run:
working-directory: ./platforms/web

jobs:
build_and_preview:
name: Build and preview
runs-on: ubuntu-latest
outputs:
output1: ${{ steps.firebase_hosting_preview.outputs.details_url }}
steps:
- uses: actions/checkout@v3
- name: Build Preview Link
env:
APP_PLAYER_LICENSE_KEY: ${{ secrets.PLAYER_LICENSE_KEY }}
run: yarn && MODE=preview yarn build
- uses: FirebaseExtended/action-hosting-deploy@v0
id: firebase_hosting_preview
with:
entryPoint: './platforms/web'
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
expires: 30d

lhci:
name: Lighthouse
runs-on: ubuntu-latest
needs: build_and_preview
steps:
- uses: actions/checkout@v3
- name: Install Lighthouse CI
run: sudo yarn global add @lhci/[email protected]
- name: Run Lighthouse CI
run: lhci autorun --collect.url=${{ needs.build_and_preview.outputs.output1 }}?app-config=gnnuzabk --config=./lighthouserc.cjs
Loading
Loading