-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDM-161] - feat: IAM Middleware #582
Conversation
…o IDM-161/IAM-Middleware
Visit the preview URL for this PR (updated for commit 72a186a): https://ottwebapp--pr582-idm-161-iam-middlewa-to3b0v49.web.app (expires Sat, 12 Oct 2024 12:24:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
Nice PR @kiremitrov123! I haven't looked much into what is needed, but I assume this middleware is needed for the frontend. Just in case, are you really sure that we can't fetch the offers from the public Stripe APIs? Perhaps we can discuss the following here:
I will review the code more thoroughly soon 😄 |
@ChristiaanScheermeijer thanks for the input! Yes, right! This middleware (access-bridge) will be used by the frontend to connect with both the SIMS and Access Control systems. It will generate/refresh passports, list Stripe products, and handle Stripe checkout sessions. Key Points:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments on the latest, but nothing blocking or that's not an easy fix!
4aca638
to
4ed8831
Compare
Co-authored-by: Mike van Veenhuijzen <[email protected]>
* chore(project): add apple smart banner tag via env var * chore(project): add android native banner data via env var * refactor(project): make code more readable * refactor(project): add itunes related application metadata * refactor(project): function rename
4ed8831
to
def9b1c
Compare
…o IDM-161/IAM-Middleware
Description
This PR sets up the initial project structure for the Access Bridge service.
A service that facilitates seamless communication between SIMS (Subscriber Identity Management System) and Access Control services. It provides endpoints to generate and refresh access passports for authenticated viewers, ensuring secure and efficient access management.
Create Initial Project Structure
Generate Passport
Refresh Passport
Add Tests
Design document: AC - Sims Integration
Related Jira cards:
Note:
There will be follow up PRs related to this one, that will include the Stripe logic needed for fetching Stripe products metadata, as well as payment initiation.
Steps completed:
According to our definition of done, I have completed the following steps: