-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JWT.Extensions.DependencyInjection #346
Conversation
577aa49
to
e50c6fb
Compare
@frankely can you please also help testing version 7.4.0? the difference is that Makes sense? |
You bet I got you @abatishchev |
@frankely gentle ping, please. your help is greatly appreciated. |
I'll get into it! Somehow I had troubles trying to find the new version. I'll try again today! |
Done @abatishchev |
You got it from here, correct? Looks good? Ship it? |
Actually, after upgrading them I'm getting errors because there is no AddJwt extension method anymore and the JwtAuthenticationDefaults and JwtAuthenticationOptions classes don't exist anymore. @abatishchev |
@frankely wait, how come? can you post a snippet of your code? i haven't changed the extension method's signature: namespace JWT
{
public static class AuthenticationBuilderExtensions
{
public static AuthenticationBuilder AddJwt(this AuthenticationBuilder builder) { ... }
public static AuthenticationBuilder AddJwt<TFactory>(this AuthenticationBuilder builder)
where TFactory : class, IAlgorithmFactory { ... } |
Sorry that I haven't looked into this, but I have been swamped with other stuff. Can you provide an example of how to use the newer version? Do you have available as a NuGet prerelease version somewhere with some docs? @abatishchev |
d789558
to
e5f47a8
Compare
@frankely sorry for the delay in response! and thanks for helping me to test the new functionality. I think the easiest way to test would be to download the packages into a folder and setup is as a local feed, if you haven't done that already. However the problem is that the package version hasn't changed so the previous version has been cached by NuGet in few places locally. So what I did is I appended both packages with `-beta1 and will increment it every time I make a change in the PR. Will drop it once we're done. Please try out the latest version from this build. |
10f5f97
to
4fa6a26
Compare
Ping, please let me know if you had a chance to try the latest build. |
4fa6a26
to
bfce3ac
Compare
@frankely, ping please. |
Hey! I'll look into this! |
398490b
to
d0c8627
Compare
I upgraded to JWT to Version="8.4.2" and it works great! |
Resolves #336