Made events async #501
Merged
Made events async #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abatishchev
reviewed
May 28, 2024
abatishchev
approved these changes
May 28, 2024
|
Released to NuGet.org as 11.0.0-beta4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was integrating the beta build into my project and noticed that I failed to make the events async/await able. This is preventing me from digging into my database to verify attributes about the JWT token in my custom Event Type.
I was careful to avoid doing any actual awaits in the framework to try and minimize the amount of "task switching" that the internal framework is doing.
Checklist