Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI build deterministic #506

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Aug 5, 2024

Description

Resolves #505 .

CI build is now configured with deterministic build flag. Artifacts contain nuget packages with proper flags:

image

Checklist

  • Tests added
  • Version bumped
  • Changelog updated

@lahma lahma marked this pull request as ready for review August 5, 2024 07:38
@abatishchev
Copy link
Member

Awesome, thanks! But does it really require publishing a new version right away? Can you please remove those changes. Since there are no other changes than this one

@lahma lahma force-pushed the make-ci-build-deterministic branch from d27160e to 7b38390 Compare August 5, 2024 17:06
@lahma
Copy link
Contributor Author

lahma commented Aug 5, 2024

I have removed the changelog and csproj changes, I thought they were necessary as they were part of the PR template.

@abatishchev abatishchev merged commit a174162 into jwt-dotnet:main Aug 5, 2024
1 check passed
@abatishchev
Copy link
Member

The template is (over) generic :) Thanks again for the contribution!

@lahma lahma deleted the make-ci-build-deterministic branch August 5, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Make build deterministic for CI
2 participants