Implement Elliptic Curve Crypto Signatures #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! Code review in progress. :) |
| @@ -37,10 +45,22 @@ def sign_rsa(algorithm, msg, private_key) | |||
| private_key.sign(OpenSSL::Digest.new(algorithm.sub('RS', 'sha')), msg) | |||
| end | |||
|
|
|||
| def sign_ecdsa(algorithm, msg, private_key) | |||
| raise IncorrectAlgorithm unless NAMED_CURVES[algorithm] == private_key.group.curve_name | |||
There was a problem hiding this comment.
Now that I look back at this. It would probably be better to raise this with a more helpful message.
There was a problem hiding this comment.
Feel free to extend you PR.
I can tag it as WIP if you want to. :)
There was a problem hiding this comment.
Sounds good, I'll update my branch. It shouldn't take me very long.
The JSON Web Algorithms draft specifies three algorithms for signatures using the Elliptic Curve Digital Signature Algorithm (ECDSA). * ES256 - ECDSA using P-256 and SHA-256 * ES384 - ECDSA using P-384 and SHA-384 * ES512 - ECDSA using P-521 and SHA-512
jtdowney
force-pushed
the
implement_ecdsa
branch
from
32749d5 to
190298a
Compare
|
@excpt I've pushed an update that includes the better error message |
|
👍 |
excpt
added a commit
that referenced
this pull request
May 9, 2015
Implement Elliptic Curve Crypto Signatures
|
@jtdowney Thank you for the contribution. Merged and released in version 1.5.0. :) 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON Web Algorithms draft specifies three algorithms for signatures using the Elliptic Curve Digital Signature Algorithm (ECDSA). This pull request adds support for: