Always use UTF-8 in GsonDeserializer #592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
in this piece of code:
new String(bytes)
will use system default Charset, whileUTF-8
should be used according to JWT RFC: https://tools.ietf.org/html/rfc7519#section-7.2So, if JVM was started with "
![jjwt_unicode](https://user-images.githubusercontent.com/10956519/82067749-cd9e6180-96d9-11ea-8c1e-3e5c71bb7664.png)
-Dfile.encoding=ISO-8859-1
" system property thenGsonDeserializer
corrupts data during deserialization: