Skip to content

Commit

Permalink
Choose Travis CI distributions to match JDKs
Browse files Browse the repository at this point in the history
Unfortunately complex matrix of Linux distribution and available JDKs.
Installs ant for OSX and Linux xenial.

--HG--
extra : amend_source : 4d9134212577a42f486ca39a915130936c55fe4c
  • Loading branch information
jeff5 committed Aug 2, 2019
1 parent f1498dc commit a345c91
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 19 deletions.
39 changes: 24 additions & 15 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,30 +1,39 @@
language: java

addons:
homebrew:
hostname: jyshort

homebrew: # only active on osx
update: true
packages: ant
packages:
- ant


matrix:
include:
- jdk: openjdk7
# - jdk: openjdk8
- jdk: oraclejdk8
# - jdk: oraclejdk9
# - jdk: oraclejdk11 # times out
- os: linux
dist: precise
jdk: oraclejdk7

This comment has been minimized.

Copy link
@cclauss

cclauss Aug 2, 2019

Contributor

Linux is already the default OS on Travis so that line is not strictly necessary but it does not hurt either. precise is end of life. It is not a good idea to recommend that users remain on an unsupported OS. https://wiki.ubuntu.com/Releases trusty is also end of life but at least it is still on extended paid support.

This comment has been minimized.

Copy link
@jeff5

jeff5 Aug 2, 2019

Author Member

I had trouble selecting JDKs that were not pre-installed. (See e.g. https://travis-ci.community/t/error-installing-oraclejdk8-expected-feature-release-number-in-range-of-9-to-14-but-got-8/3766/3). We currently intend Jython to work on 7. This is in question, and we might officially say 8. I expect this to disappear after 2.7.2.


- os: linux
dist: xenial

This comment has been minimized.

Copy link
@cclauss

cclauss Aug 2, 2019

Contributor

Xenial is now the Travis default distro so that line is not strictly necessary but it does not hurt either. https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment

This comment has been minimized.

Copy link
@jeff5

jeff5 Aug 2, 2019

Author Member

Treat as documentation.

addons:
apt:
packages:
- ant

This comment has been minimized.

Copy link
@cclauss

cclauss Aug 2, 2019

Contributor

If we only have one package to install then packages: ant can be on a single line for brevity.

This comment has been minimized.

Copy link
@jeff5

jeff5 Aug 2, 2019

Author Member

I only learned YAML at the weekend, so I'm keeping it regular.

jdk: openjdk11

- os: osx
name: "JDK: oraclejdk10 Java on macOS"
install: export JAVA_HOME=$(/usr/libexec/java_home)
osx_image: xcode9.3 # Last supporting Java 8
jdk: oraclejdk8

This comment has been minimized.

Copy link
@cclauss

cclauss Aug 2, 2019

Contributor

Will Jython work on more current JDKs?

This comment has been minimized.

Copy link
@jeff5

jeff5 Aug 2, 2019

Author Member

I'd have chosen 12 (GA) if I hadn't had the earlier problems. I don't want to hammer Travis with a lot of jobs: they're giving us this for free (I think).

This comment has been minimized.

Copy link
@cclauss

cclauss Aug 2, 2019

Contributor

Yes. They give for free and it is good to keep the number of jobs reasonable.


addons:
hostname: jyshort

before_install:
- cat /etc/hosts # optionally check the content *after*
install:
- ant developer-build

install: ant

script: ant && ant regrtest-travis
script:
- ant regrtest-travis

notifications:
email:
Expand Down
9 changes: 5 additions & 4 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1106,13 +1106,14 @@ The readme text for the next release will be like:
<arg value="-w"/> <!-- re-run failed tests in verbose mode -->
<!-- Only run the tests that are expected to work on Jython -->
<arg value="--expected"/>
<arg value="-j"/>
<arg value="${junit.reports}"/>
<arg value="--use"/>
<arg value="network,subprocess"/>
<!-- Exclude particular tests troublesome on the build bots -->
<arg value="--exclude"/>
<arg value="test_gc"/> <!-- intermittently fails/hangs (xenial) -->
<arg value="test_mailbox"/>
<arg value="test_select_new"/>
<arg value="test_smtpnet"/>
<arg value="test_socket"/>
</exec>
</target>
Expand All @@ -1124,13 +1125,13 @@ The readme text for the next release will be like:
<arg value="-w"/> <!-- re-run failed tests in verbose mode -->
<!-- Only run the tests that are expected to work on Jython -->
<arg value="--expected"/>
<arg value="-j"/>
<arg value="${junit.reports}"/>
<arg value="--use"/>
<arg value="network,subprocess"/>
<!-- Exclude particular tests troublesome on the build bots -->
<arg value="--exclude"/>
<arg value="test_mailbox"/>
<arg value="test_select_new"/>
<arg value="test_smtpnet"/>
<arg value="test_socket"/>
</exec>
</target>
Expand Down

0 comments on commit a345c91

Please sign in to comment.