fix(dynamic_conf) fix watch

fix(dynamic_conf) fix watch fix(dynamic_conf) fix watch fix(dynamic_conf) fix watch fix(dynamic_conf) fix watch
jzero-io · Dec 19, 2024 · 776d556 · 776d556
1 parent 07bad4b
commit 776d556
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/dynamic_conf/fsnotify.go b/dynamic_conf/fsnotify.go
@@ -2,6 +2,7 @@ package dynamic_conf
 
 import (
 	"os"
+	"path/filepath"
 
 	"github.com/fsnotify/fsnotify"
 	"github.com/zeromicro/go-zero/core/configcenter/subscriber"
@@ -35,7 +36,8 @@ func (lf *FsNotify) AddListener(listener func()) error {
 				if !ok {
 					return
 				}
-				if event.Has(fsnotify.Write) {
+				logx.Infof("%s %s", event.Name, event.Op)
+				if event.Has(fsnotify.Write) || event.Has(fsnotify.Rename) {
 					listener()
 				}
 			case err, ok := <-lf.Watcher.Errors:
@@ -47,7 +49,8 @@ func (lf *FsNotify) AddListener(listener func()) error {
 		}
 	}()
 
-	if err := lf.Watcher.Add(lf.Path); err != nil {
+	// see: https://github.com/fsnotify/fsnotify/issues/363
+	if err := lf.Watcher.Add(filepath.Dir(lf.Path)); err != nil {
 		return err
 	}
 	return nil