Actuator enhancements #161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mdbooth
commented
Dec 20, 2024
mdbooth
commented
- Actuator has GetObject() instead of implementing client.Object
- Generic finalizer handling
- Remove unnecessary controller constants
- Add ResourceControllerCommon
Move finalizer creation and deletion into generic methods. This ensures that it is done consistently. This also ensures that we don't add a finalizer until after we have an authenticated openstack client. This prevents a situation when creating objects with invalid credentials where the objects can't be deleted without first fixing the credentials, which is unnecessary as they could never have resulted in the creation of an OpenStack resource.
Removing ID transaction also highlights controllers which still needed to be updated to use merge for status ID.
Reconcilers now implement ResourceControllerCommon, which allows finalizer name and field owner to be used consistently in actuators and SetupWithManager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.