Fixes eclipse-tycho#342: Run surefire tests outside of lock

Running tests while the lock is present leads to the tests being executed in series which severely degrades performance when the build is running with parallel maven projects.
k-spa · Nov 25, 2021 · 064f756 · 064f756
1 parent 65b2d37
commit 064f756
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...fire/tycho-surefire-plugin/src/main/java/org/eclipse/tycho/surefire/AbstractTestMojo.java b/...fire/tycho-surefire-plugin/src/main/java/org/eclipse/tycho/surefire/AbstractTestMojo.java
@@ -673,8 +673,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             return;
         }
         if (shouldRun()) {
+            EquinoxInstallation equinoxTestRuntime;
             synchronized (LOCK) {
-                EquinoxInstallation equinoxTestRuntime;
                 if ("p2Installed".equals(testRuntime)) {
                     equinoxTestRuntime = createProvisionedInstallation();
                 } else if ("default".equals(testRuntime)) {
@@ -683,9 +683,9 @@ public void execute() throws MojoExecutionException, MojoFailureException {
                     throw new MojoExecutionException("Configured testRuntime parameter value '" + testRuntime
                             + "' is unkown. Allowed values: 'default', 'p2Installed'.");
                 }
-                if (equinoxTestRuntime != null) {
-                    runTest(equinoxTestRuntime);
-                }
+            }
+            if (equinoxTestRuntime != null) {
+                runTest(equinoxTestRuntime);
             }
         }
     }