Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce check-metricsscraper-singlenode #4419

Merged
merged 2 commits into from
May 16, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented May 15, 2024

Description

This is a variant of check-metricsscraper that executes the inttest on a single-node cluster. This mainly means that, in addition to etcd, kine scraping is also tested. Use the JSON API and look for the push_time_seconds metric. Collect all job labels that had successful pushes and compare it to the list of expected jobs.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

twz123 added 2 commits May 16, 2024 10:57
Use the JSON API and look for the push_time_seconds metric. Collect all
job labels that had successful pushes.

Signed-off-by: Tom Wieczorek <[email protected]>
This is a variant of check-metricsscraper that executes the inttest on
a single-node cluster. This mainly means that, in addition to etcd, kine
scraping is also tested.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the metricsscraper-singlenode-inttest branch from 170f0d2 to 62beca8 Compare May 16, 2024 08:57
@twz123 twz123 marked this pull request as ready for review May 16, 2024 12:04
@twz123 twz123 requested a review from a team as a code owner May 16, 2024 12:04
@twz123 twz123 requested review from ncopa and juanluisvaladas May 16, 2024 12:04
@twz123 twz123 added the backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch label May 16, 2024
@twz123 twz123 merged commit 7b44460 into k0sproject:main May 16, 2024
78 checks passed
@twz123 twz123 deleted the metricsscraper-singlenode-inttest branch May 16, 2024 14:20
@k0s-bot
Copy link

k0s-bot commented May 16, 2024

Successfully created backport PR for release-1.30:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/smoke-tests backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants