Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine new etcd member join names via etcd extra-args #4613

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Determine new etcd member join names via etcd extra-args #4613

merged 1 commit into from
Jul 9, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 13, 2024

Description

This allows for overriding the etcd member name via the extraArgs setting.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 marked this pull request as ready for review June 13, 2024 10:49
@twz123 twz123 requested a review from a team as a code owner June 13, 2024 10:49
@twz123 twz123 requested review from kke and makhov June 13, 2024 10:49
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123 twz123 force-pushed the etcd-join-member-names branch from dfaaebf to 6aec9ca Compare June 18, 2024 07:48
@twz123
Determine new etcd member join names via etcd extra-args
fc4b155 
This allows for overriding the etcd member name via the extraArgs
setting.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the etcd-join-member-names branch from 6aec9ca to fc4b155 Compare June 18, 2024 08:13
ncopa
ncopa previously approved these changes Jun 24, 2024
View reviewed changes
@twz123 twz123 dismissed ncopa’s stale review June 24, 2024 11:02

The merge-base changed after approval.

makhov
makhov previously approved these changes Jun 25, 2024
View reviewed changes
@twz123 twz123 dismissed makhov’s stale review June 25, 2024 09:40

The merge-base changed after approval.

@twz123 twz123 requested review from ncopa and makhov June 25, 2024 14:13
@twz123 twz123 merged commit 6e6f88a into k0sproject:main Jul 9, 2024
79 checks passed
@twz123 twz123 deleted the etcd-join-member-names branch July 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

@ncopa ncopa Awaiting requested review from ncopa

@makhov makhov Awaiting requested review from makhov

Assignees
No one assigned
Labels
area/configuration component/etcd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twz123 @ncopa @makhov @jnummelin