Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run libseccomp tests in parallel #5076

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Run libseccomp tests in parallel #5076

merged 1 commit into from
Oct 17, 2024

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Oct 4, 2024 •
edited
Loading

Backport a commit that allows us to run the libseccomp tests in parallel. This lets us build runc image in 30-40 seconds instead of 4-5 minutes.

The bash script uses tail options that is not supported in busybox tail so pull in tail from coreutils.

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ncopa ncopa requested a review from a team as a code owner October 4, 2024 08:26
@ncopa ncopa requested review from twz123 and jnummelin October 4, 2024 08:26
@ncopa ncopa added the chore label Oct 4, 2024
@ncopa ncopa force-pushed the parallel-seccomp-tests branch from e06a866 to 9746257 Compare October 4, 2024 08:27
twz123
twz123 reviewed Oct 4, 2024
View reviewed changes
@ncopa
Run libseccomp tests in parallel
165d4da 
Backport a commit that allows us to run the libseccomp tests in
parallel. This lets us build runc image in 30-40 seconds instead
of 4-5 minutes.

The bash script uses `tail` options that is not supported in busybox
tail so pull in `tail` from coreutils.

Signed-off-by: Natanael Copa <[email protected]>
@ncopa ncopa force-pushed the parallel-seccomp-tests branch from 9746257 to 165d4da Compare October 9, 2024 12:53
@ncopa ncopa requested a review from twz123 October 9, 2024 13:14
@ncopa ncopa merged commit 9a7b4d1 into k0sproject:main Oct 17, 2024
89 checks passed
@ncopa ncopa deleted the parallel-seccomp-tests branch October 17, 2024 11:55
@twz123
Copy link
Member

twz123 commented Nov 14, 2024

Let's see if we can backport this ...

@twz123 twz123 added the backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch label Nov 14, 2024
@k0s-bot
Copy link

k0s-bot commented Nov 14, 2024

Successfully created backport PR for release-1.31:

@k0s-bot k0s-bot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

@twz123 twz123 Awaiting requested review from twz123

Assignees
No one assigned
Labels
backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncopa @twz123 @k0s-bot @juanluisvaladas