[Backport release-1.31] Correctly detect DNS address computation errors #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code is unable to compute meaningful DNS addresses if the service CIDR doesn't describe a v4 network. Error out whenever the network IP is not a v4 address until it is clear how to properly compute the DNS address for a v6 network. Also, copy `address` by value so that changes to it don't change `ipnet` as well. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 6824326)
16 tasks
twz123
added
bug
jnummelin
approved these changes
Nov 20, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.30
git worktree add -d .worktree/backport-5270-to-release-1.30 origin/release-1.30
cd .worktree/backport-5270-to-release-1.30
git switch --create backport-5270-to-release-1.30
git cherry-pick -x de3071132ccd4f4450b5c1eabe930780d20070fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.31, triggered by a label in #5236.See .