Provide several sub-commands only on Linux #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
linux-only-subcommands
branch
2 times, most recently
from
f95db7d to
529dae8
Compare
|
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
linux-only-subcommands
branch
from
529dae8 to
53c9965
Compare
twz123
force-pushed
the
linux-only-subcommands
branch
3 times, most recently
from
c84a9bf to
07ee5e9
Compare
|
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
linux-only-subcommands
branch
from
07ee5e9 to
2db976c
Compare
juanluisvaladas
previously approved these changes
Jan 7, 2025
jnummelin
previously approved these changes
Jan 7, 2025
twz123
force-pushed
the
linux-only-subcommands
branch
6 times, most recently
from
d59a517 to
cd7b466
Compare
|
This pull request has merge conflicts that need to be resolved. |
On Windows, there's no numeric UIDs, so using this there is futile. Signed-off-by: Tom Wieczorek <[email protected]>
...and harmonize the status-socket flag in the status sub-command. The shared use of the StatusSocket variable, along with the non-empty default value in the status sub-command, caused the registration order of sub-commands to change the flag value for each sub-command, even if it wasn't set from the command line. This broke the configuration defaulting. Signed-off-by: Tom Wieczorek <[email protected]>
Configuration loading, validation, and user setup are required only for controllers. Inline this functionality into their commands, making the worker command lighter. Signed-off-by: Tom Wieczorek <[email protected]>
They won't work on non-Linux systems anyways. Use build flags to add platform-specific sub-commands instead of runtime checks. Also add build tag to files that only make sense on specific platforms. This includes Autopilot, as this relies on the status socket, which is not available on Windows at the moment. Signed-off-by: Tom Wieczorek <[email protected]>
twz123
force-pushed
the
linux-only-subcommands
branch
from
cd7b466 to
90fb8e2
Compare
jnummelin
approved these changes
Jan 9, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
They won't work on non-Linux systems anyways. Use build flags to add platform-specific sub-commands instead of runtime checks. Also add build tag to files that only make sense on specific platforms. This includes Autopilot, as this relies on the status socket, which is not available on Windows at the moment.
Inline setup function for install commands: Configuration loading, validation, and user setup are required only for controllers. Inline this functionality into their commands, making the worker command lighter.
Compile
users.LookupUIDvia build tags. On Windows, there's no numeric UIDs, so using this there is futile.Type of change
How Has This Been Tested?
Checklist: